Bug 260159 - [exp-run] lld nostart-stop-gc default behaviour
Summary: [exp-run] lld nostart-stop-gc default behaviour
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-01 20:18 UTC by Ed Maste
Modified: 2023-03-01 15:55 UTC (History)
3 users (show)

See Also:


Attachments
patch to restore lld 12.0 behaviour wrt start-stop-gc (979 bytes, patch)
2021-12-01 20:18 UTC, Ed Maste
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer freebsd_triage 2021-12-01 20:18:07 UTC
Created attachment 229833 [details]
patch to restore lld 12.0 behaviour wrt start-stop-gc

Note, this is an "inverse" exp-run - I am interested in ports that newly build with this change (rather than ports that newly fail).

lld before 13.0 defaulted to -nostart-stop-gc, and the 13.0 update switched it to -start-stop-gc by default. Most issues relating to the LLVM 13 update were addressed via the exp-run in PR 258209, but there may have been some leaf port failures due to this lld change that were not addressed.

This change restores the default to match lld 12.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2021-12-05 07:42:56 UTC
These failures seem to be fixed by the patch:

http://gohan03.nyi.freebsd.org/data/main-amd64-default-baseline/p95394a8fd25d_scbe9faa50b/logs/errors/igv-2.9.4.log
http://gohan03.nyi.freebsd.org/data/main-amd64-default-baseline/p95394a8fd25d_scbe9faa50b/logs/errors/firebird25-client-2.5.9_1.log
http://gohan03.nyi.freebsd.org/data/main-amd64-default-baseline/p95394a8fd25d_scbe9faa50b/logs/errors/dub-1.14.0.log
http://gohan03.nyi.freebsd.org/data/main-amd64-default-baseline/p95394a8fd25d_scbe9faa50b/logs/errors/ghidra-9.1.log
http://gohan03.nyi.freebsd.org/data/main-amd64-default-baseline/p95394a8fd25d_scbe9faa50b/logs/errors/apache-openoffice-4.1.11.log
http://gohan03.nyi.freebsd.org/data/main-amd64-default-baseline/p95394a8fd25d_scbe9faa50b/logs/errors/apache-openoffice-devel-4.2.1633255994,4.log
http://gohan03.nyi.freebsd.org/data/main-amd64-default-baseline/p95394a8fd25d_scbe9faa50b/logs/errors/pioneer-20210723_1.log
http://gohan03.nyi.freebsd.org/data/main-amd64-default-baseline/p95394a8fd25d_scbe9faa50b/logs/errors/signald-0.15.0.log
http://gohan03.nyi.freebsd.org/data/main-amd64-default-baseline/p95394a8fd25d_scbe9faa50b/logs/errors/onedrive-2.4.12.log
http://gohan03.nyi.freebsd.org/data/main-amd64-default-baseline/p95394a8fd25d_scbe9faa50b/logs/errors/keepass-2.46.log
http://gohan03.nyi.freebsd.org/data/main-amd64-default-baseline/p95394a8fd25d_scbe9faa50b/logs/errors/reptyr-0.8.0.log
http://gohan03.nyi.freebsd.org/data/main-amd64-default-baseline/p95394a8fd25d_scbe9faa50b/logs/errors/gtk-sharp-beans-2.14.1_1.log
http://gohan03.nyi.freebsd.org/data/main-amd64-default-baseline/p95394a8fd25d_scbe9faa50b/logs/errors/gtkd-3.9.0.log
Comment 2 Fangrui Song 2021-12-06 17:49:31 UTC
devel/dub, x11-toolkits/gtkd, and net/onedrive are due to ldc (https://github.com/ldc-developers/ldc/issues/3861): `ld: error: undefined hidden symbol: __start_minfo`. (Quick workaround is to remove --gc-sections from ldc source)

All other ports appear unrelated to the linker change.
Comment 3 Ed Maste freebsd_committer freebsd_triage 2021-12-06 20:28:10 UTC
(In reply to Fangrui Song from comment #2)

Thanks for triaging these.
Comment 4 Ed Maste freebsd_committer freebsd_triage 2023-03-01 15:55:16 UTC
We have moved beyond lld 12/13 in FreeBSD