Created attachment 229836 [details] update to 1.31.4 and set X11MON as default option I submit a new version of deskutils/recoll port. There are some functional changes and style changes: Style changes ============= After to pass portfmt, portclippy and portlint, some chunks of text have been reordered. Update port version =================== Update version from 1.31.2 to 1.31.4. See changelog https://www.lesbonscomptes.com/recoll/pages/release-1.31.html BINARY_ALIAS ============ To simplify the files/patch-Makefile.in patch, I have added: BINARY_ALIAS= python2=${FALSE} python3=${PYTHON_CMD} Change default options ====================== See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260093 X11MON option is now a default option, as only adds a few dependencies very common in a desktop installation. Update port description ======================= Recoll depends on QT version 5, not version 4. The port passes poudriere testport in 130R, 122R releases in amd64 and i386 archs, with the default options, full options, and no option.
1.31.5 is available: > Fix temporary files cleanup when using tesseract OCR on PDF files. For what it's worth, I'd like to have 1.31.4 sooner (rather than later, for 1.31.5). To tell whether my indexing bug 260772 is reproducible. Thanks
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval. -- Attachment -> Details -> maintainer-approval [+] ^Triage: Maintainer-feedback flag (+) not required unless requested (?) first. Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=37991a7381a067c2e744e7debafcf18aef664e35 commit 37991a7381a067c2e744e7debafcf18aef664e35 Author: Jose G. Juanino <jjuanino@gmail.com> AuthorDate: 2022-02-01 10:54:48 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-02-01 14:27:00 +0000 deskutils/recoll: update to 1.31.4 and set X11MON as default option ChangeLog: https://www.lesbonscomptes.com/recoll/pages/release-1.31.html This should fix PR260772 too. PR: 260162 Reported by: jjuanino@gmail.com deskutils/recoll/Makefile | 104 ++++++++++------------ deskutils/recoll/distinfo | 6 +- deskutils/recoll/files/patch-Makefile.in | 40 +-------- deskutils/recoll/files/patch-utils_fstreewalk.cpp | 4 +- deskutils/recoll/pkg-descr | 2 +- 5 files changed, 56 insertions(+), 100 deletions(-)
Committed, Thanks!
Fernando, This PR had been assigned (thus a courtesy ping would be appreciated), and also proposed patch contained an ugly mix of functional and dubious formatting changes that should have been committed separately, if at all.
(In reply to Alexey Dokuchaev from comment #5) I'm so sorry Alexey, I think I had this PR opened in a tab for too long and didn't refresh it. When I was to close it bugzilla warned about other changes, but I though it was the commit message itself and didn't check if other changes had taken place. Apologies again.
(In reply to Fernando Apesteguía from comment #6) > Apologies again. No worries! Thanks for getting back though, appreciated.