Bug 260355 - [x11-toolkits/qt5-quick3d] v5.15.2, compilation failure against assimp v5.1.0
Summary: [x11-toolkits/qt5-quick3d] v5.15.2, compilation failure against assimp v5.1.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-12 11:34 UTC by Bertrand Petit
Modified: 2021-12-19 17:10 UTC (History)
2 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bertrand Petit 2021-12-12 11:34:59 UTC
Qt5 v5.15.2 can not be installed because qt5-quick3d can not be compiled against against assimp 5.1.0.

The reported error is:

c++ -c -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -std=c++1z -fvisibility=hidden -fvisibility-inlines-hidden -fno-exceptions -Wall -Wex
tra -Wdate-time -Winconsistent-missing-override -pthread -fPIC -DQT_NO_LINKED_LIST -DQT_NO_FOREACH -DQT_DEPRECATED_WARNINGS -DQT_NO_NARROWING_CONVER
SIONS_IN_CONNECT -DQT_NO_EXCEPTIONS -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_NO_DEBUG -DQT_PLUGIN -DQT_QUICK3DASSETIMPORT_LIB -DQT_QUICK3DREND
ER_LIB -DQT_QUICK3DUTILS_LIB -DQT_QUICK_LIB -DQT_GUI_LIB -DQT_QMLMODELS_LIB -DQT_QML_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -I../../../../include/Qt
Quick3DAssetImport/5.15.2 -I../../../../include/QtQuick3DAssetImport/5.15.2/QtQuick3DAssetImport -I../../../../include/QtQuick3DRender/5.15.2 -I../.
./../../include/QtQuick3DRender/5.15.2/QtQuick3DRender -I../../../../include/QtQuick3DUtils/5.15.2 -I../../../../include/QtQuick3DUtils/5.15.2/QtQui
ck3DUtils -I../../../../include -I../../../../include/QtQuick3DAssetImport -I../../../../include/QtQuick3DRender -I../../../../include/QtQuick3DUtil
s -I/usr/local/include/qt5/QtGui/5.15.2 -I/usr/local/include/qt5/QtGui/5.15.2/QtGui -I/usr/local/include/qt5 -I/usr/local/include/qt5/QtQuick -I/usr
/local/include/qt5/QtGui -I/usr/local/include/qt5/QtCore/5.15.2 -I/usr/local/include/qt5/QtCore/5.15.2/QtCore -I/usr/local/include/qt5/QtQmlModels -
I/usr/local/include/qt5/QtQml -I/usr/local/include/qt5/QtNetwork -I/usr/local/include/qt5/QtCore -I.moc -I/usr/local/include -I/usr/local/include -I
/usr/local/lib/qt5/mkspecs/freebsd-clang -o .obj/assimpimporter.o assimpimporter.cpp
assimpimporter.cpp:952:36: error: use of undeclared identifier 'AI_MATKEY_GLTF_PBRMETALLICROUGHNESS_BASE_COLOR_FACTOR'
            result = material->Get(AI_MATKEY_GLTF_PBRMETALLICROUGHNESS_BASE_COLOR_FACTOR, baseColorFactor);
                                   ^
assimpimporter.cpp:960:62: error: use of undeclared identifier 'AI_MATKEY_GLTF_PBRMETALLICROUGHNESS_BASE_COLOR_TEXTURE'
            QString baseColorImage = generateImage(material, AI_MATKEY_GLTF_PBRMETALLICROUGHNESS_BASE_COLOR_TEXTURE, tabLevel + 1);
                                                             ^
assimpimporter.cpp:978:36: error: use of undeclared identifier 'AI_MATKEY_GLTF_PBRMETALLICROUGHNESS_METALLIC_FACTOR'
            result = material->Get(AI_MATKEY_GLTF_PBRMETALLICROUGHNESS_METALLIC_FACTOR, metallicFactor);
                                   ^
assimpimporter.cpp:988:36: error: use of undeclared identifier 'AI_MATKEY_GLTF_PBRMETALLICROUGHNESS_ROUGHNESS_FACTOR'
            result = material->Get(AI_MATKEY_GLTF_PBRMETALLICROUGHNESS_ROUGHNESS_FACTOR, roughnessFactor);
                                   ^
assimpimporter.cpp:1075:36: error: use of undeclared identifier 'AI_MATKEY_GLTF_UNLIT'
            result = material->Get(AI_MATKEY_GLTF_UNLIT, isUnlit);
                                   ^
assimpimporter.cpp:1082:32: error: use of undeclared identifier 'AI_MATKEY_GLTF_PBRSPECULARGLOSSINESS'
        result = material->Get(AI_MATKEY_GLTF_PBRSPECULARGLOSSINESS, hasSpecularGlossiness);
                               ^   
assimpimporter.cpp:1112:40: error: use of undeclared identifier 'AI_MATKEY_GLTF_PBRSPECULARGLOSSINESS_GLOSSINESS_FACTOR'
                result = material->Get(AI_MATKEY_GLTF_PBRSPECULARGLOSSINESS_GLOSSINESS_FACTOR, glossiness);
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2021-12-12 12:58:55 UTC
Moin moin 

Are you using the quarterly-branch of the  ports tree or main?

mfg Tobias
Comment 2 Bertrand Petit 2021-12-13 09:28:17 UTC
The used ports tree was portsnaped on December 7th at 19:42, I suppose this tree is not from quarterly.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-12-18 17:36:16 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b452cf359ea6344ebe8fd3bf0ef91029a9a8626f

commit b452cf359ea6344ebe8fd3bf0ef91029a9a8626f
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2021-12-18 17:20:44 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2021-12-18 17:35:53 +0000

    x11-toolkits/qt5-quick3d: switch to use bundled assimp

    Quick3d is at the moment not compatible with assimp-5.1.0. In poudriere,
    due to assimp not being available, the port was already built with the
    bundled assimp version.

    For builds in a non-clean-room environment, explitely specify, that we
    want the bundled one too.

    PR:             260355
    Reported by:    Bertrand Petit <bsdpr@phoe.frmug.org>

 x11-toolkits/qt5-quick3d/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-12-18 17:42:19 UTC
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8bf5428a441be3d28e2ede460fe5d57ab663b462

commit 8bf5428a441be3d28e2ede460fe5d57ab663b462
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2021-12-18 17:20:44 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2021-12-18 17:39:34 +0000

    x11-toolkits/qt5-quick3d: switch to use bundled assimp

    Quick3d is at the moment not compatible with assimp-5.1.0. In poudriere,
    due to assimp not being available, the port was already built with the
    bundled assimp version.

    For builds in a non-clean-room environment, explitely specify, that we
    want the bundled one too.

    PR:             260355
    Reported by:    Bertrand Petit <bsdpr@phoe.frmug.org>

    (cherry picked from commit b452cf359ea6344ebe8fd3bf0ef91029a9a8626f)

 x11-toolkits/qt5-quick3d/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 5 Tobias C. Berner freebsd_committer freebsd_triage 2021-12-18 17:45:21 UTC
Moin moin

Should be fixed now.

mfg Tobias
Comment 6 Bertrand Petit 2021-12-19 17:10:11 UTC
(In reply to Tobias C. Berner from comment #5)
Thank you, I confirm the correctness of the fix.