Bug 260416 - www/gitlab-ce: Quarterly fails to run: Unable to load application: NameError: uninitialized constant Sidekiq::JobLogger
Summary: www/gitlab-ce: Quarterly fails to run: Unable to load application: NameError:...
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Matthias Fechner
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2021-12-14 16:25 UTC by Marko Cupać
Modified: 2021-12-15 09:37 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mfechner)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marko Cupać 2021-12-14 16:25:49 UTC
Hi,

would it be possible to get functional www/gitlab-ce port in quarterly (2021Q4) please?

I have a few annoying problems with 13.0-RELEASE / main ports combination I hoped to avoid by using 12.3-RELEASE and quarterly (2021Q4) ports.

I just fund out the hard way that gitlab-ce-14.4.0, which is quarterly version for both 12.3-RELEASE and 13.0-RELEASE, does not work:

https://gitlab.com/gitlab-org/gitlab/-/issues/343695

Also, would it be possible to test gitlab-ce versions before them being pushed to ports tree, most important to quarterly but also to main? I am thankful for quick releases of new versions, but I suggest they are tested at least on currently supported amd64 versions, not that they just compile, but that they actually run after clean install, or after upgrade from previous version. I would be glad to help with testing. 

Thank you in advance,
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-12-14 21:29:23 UTC
(In reply to Marko Cupać from comment #0)

Does gitlab have a test suite bundled with the distribution file? If so, it would be good to get a test target and TEST_DEPENDS added to the port to ease and improve QA
Comment 2 Matthias Fechner freebsd_committer freebsd_triage 2021-12-15 06:23:01 UTC
As noted in the manual, if you use Gitlab, it is suggested to not use the quarterly branch.
I try to get updates merged into quarterly but after 2-3 weeks there are so many changes that merging to quarterly is nearly impossible (gitlab has more than 400 dependencies).

But what we faced here was a core bug, that even gitlab itself was not aware of. And as quarterly branch is created beginning of the next quarter the bug went into the quarterly branch. So even if we would run the tests (which is not easy, as you would need a infrastructure FreeBSD cannot provide) it would have not detected.

If you would like to have a reliable FreeBSD system with gitlab running, use the current ports and not quarterly branch.
Comment 3 Marko Cupać 2021-12-15 09:17:20 UTC
Hi,

I think it was not appropriate to close this PR, specially not with "Not A Bug".

The reality is that gitlab-ce-14.4.0, which is default on currently supported versions of FreeBSD, does not run. People installing it should somehow be informed it does not work (broken? pkg-message? open PR in bugzilla? warning on https://gitlab.fechner.net/mfechner/Gitlab-docu/blob/master/install/14.4-freebsd.md with link to https://gitlab.com/gitlab-org/gitlab/-/issues/343695 ?).

As described in https://gitlab.com/gitlab-org/gitlab/-/issues/343695 this bug was not rendering gitlab's official distribution unusable, just FreeBSD port which uses devel/rubygem-sidekiq-cron 1.2.0 as opposed to 1.0.4 used by official distribution.

Manual notes that "In order to get the latest version and timely security patches it may be necessary to switch to 'latest' instead of 'quarterly' packages.", not "in order to run it at all one has to switch to 'latest', as quarterly does not run".

It is quite easy for me to run main ports tree as I build my packages in my own poudriere, for 12.3 and 13.0, both main and 2021Q4, for two different sets, workstation and server. The problem is I keep flipping forth and back because one time main is broken so I need to go back to quarterly, the other time quarterly is broken so I need to go forward to main.

Please don't understand this as criticism, I am really thankful that FreeBSD has gitlab port at all, being unofficially unsupported by upstream. However, I think there is room for improvement of usability of the port. I have role-based ansible playbooks for spinning up gitlab jails with oneliners on 12.3 and 13.0, from either main, quarterly or custom ports trees. I would be glad to give new gitlab ports a spin before they hit official tree. If you think they would be helpful, I can also share my playbooks.

Best regards,
Comment 4 Matthias Fechner freebsd_committer freebsd_triage 2021-12-15 09:37:25 UTC
Dear Marko,

thanks a lot for you feedback.
The main branch should have always a working version of Gitlab. I use this branch to build packages and roll them out to all Gitlab servers maintained by myself.

Commits I do, are tested. But testing is time consuming and it can be that a dependencies was updated in the meantime that break Gitlab and this can overlap with the time it takes to test.
But this is normally fixed in 1-2 days after I noticed it. So please feel free if Gitlab in main does not work to open a ticket or write an email to me.

I have also two scripts to spin up gitlab servers quickly. One is using CBSD (with jails):
https://gitlab.fechner.net/mfechner/gitlab-cbsd

Another one is using virtualbox (with vagrant and ansible):
https://gitlab.fechner.net/mfechner/Gitlab-vagrant

I will change the status to "Not Accepted" as a status "Won't fix" does not exist.
To make the current version available many commits from many committers needs to be merged, with a risk to break other ports depending on like nodejs. Anyway the quarterly branch will be updated in two weeks and would also unblock this situation.