Bug 260925 - x11/rofi: update to 1.7.2
Summary: x11/rofi: update to 1.7.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL: https://github.com/davatorium/rofi/re...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-04 14:51 UTC by Ronald Klop
Modified: 2022-01-07 07:19 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (nomoo)


Attachments
git diff in x11/rofi (2.21 KB, patch)
2022-01-04 14:51 UTC, Ronald Klop
ronald-lists: maintainer-approval?
Details | Diff
git diff in x11/rofi-wayland (1.56 KB, patch)
2022-01-04 18:18 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ronald Klop 2022-01-04 14:51:25 UTC
Created attachment 230694 [details]
git diff in x11/rofi

- trivial version bumps
- make stage-qa ok
- compiles on aarch64/14-CURRENT

requested in https://lists.freebsd.org/archives/freebsd-ports/2022-January/001216.html

NB: I don't use this software so not runtime tested.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-04 17:53:39 UTC
Some files were missing from pkg-plist:

Error: Orphaned: %%DATADIR%%/themes/docu.rasi
Error: Orphaned: %%DATADIR%%/themes/iggy.jpg
Error: Orphaned: %%DATADIR%%/themes/iggy.rasi

No need to update a new patch.
Comment 2 Jan Beich freebsd_committer freebsd_triage 2022-01-04 18:18:17 UTC
Created attachment 230703 [details]
git diff in x11/rofi-wayland

GH_TAGNAME change breaks x11/rofi-wayland (slave port). Updating is enough to unbreak.

$ make checksum TRYBROKEN= MASTER_SITE_BACKUP= DISTDIR=$(mktemp -dt distfiles)
[...]
=> Either /usr/ports/x11/rofi-wayland/distinfo is out of date, or
=> sardemff7-libgwater-1db5b4b_GH0.tar.gz is spelled incorrectly.
*** Error code 1
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-04 18:35:36 UTC
(In reply to Jan Beich from comment #2)
Thanks for the patch.

All x11/rofi* ports build fine in 12.2{amd64,i386}, 13amd64 and current-amd64

Runs fine in 13amd64.

Waiting a couple of days for maintainer feedback.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-01-07 07:19:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9ba02dbf060b4791cff92d37e87469610cc57dce

commit 9ba02dbf060b4791cff92d37e87469610cc57dce
Author:     Ronald Klop <ronald-lists@klop.ws>
AuthorDate: 2022-01-04 17:44:43 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-01-07 07:14:57 +0000

    x11/rofi{-wayland}: update to 1.7.2

    rofi-wayland update following update of x11/rofi provided by jbeich@

    ChangeLog: https://github.com/davatorium/rofi/releases/tag/1.7.2

    PR:     260925
    Reported by:    ronald-lists@klop.ws
    Approved by:    nomoo@nomoo.ru (maintainer timeout)

 x11/rofi-wayland/Makefile |  4 ++--
 x11/rofi-wayland/distinfo | 14 +++++++-------
 x11/rofi/Makefile         |  7 ++++---
 x11/rofi/distinfo         | 14 +++++++-------
 x11/rofi/pkg-plist        |  3 +++
 5 files changed, 23 insertions(+), 19 deletions(-)
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-07 07:19:55 UTC
Committed,

Thanks!