Bug 261093 - games/retroarch: update to 1.10.0
Summary: games/retroarch: update to 1.10.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://github.com/libretro/RetroArch...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-10 18:49 UTC by Daniel Menelkir
Modified: 2022-01-30 16:44 UTC (History)
2 users (show)

See Also:
fernape: maintainer-feedback+


Attachments
v1 (2.61 KB, patch)
2022-01-10 18:49 UTC, Daniel Menelkir
no flags Details | Diff
retroarch-v2 (1.08 KB, patch)
2022-01-25 18:36 UTC, Daniel Menelkir
no flags Details | Diff
libretro-core-info-v1 (1012 bytes, patch)
2022-01-25 18:36 UTC, Daniel Menelkir
no flags Details | Diff
0001-games-libretro-core-info-update-to-1.10.0.patch (12.09 KB, patch)
2022-01-26 20:40 UTC, Val Packett
val: maintainer-approval+
Details | Diff
0001-games-retroarch-update-to-1.10.0.patch (5.48 KB, patch)
2022-01-26 20:42 UTC, Val Packett
val: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Menelkir 2022-01-10 18:49:39 UTC
Created attachment 230888 [details]
v1

Several changes since 1.9.7 as listed here: https://github.com/libretro/RetroArch/blob/master/CHANGES.md
It builds fine as expected, and this time I've attached libretro-core-info update to 1.9.14 as well so those packages will not be out of sync in ports.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-21 12:00:53 UTC
Why are these PR's being closed?

What are the events that prompt this?
Comment 2 Daniel Menelkir 2022-01-21 13:15:58 UTC
(In reply to Fernando Apesteguía from comment #1)
I'm not the maintainer, I was updating in a matter of niceness, since I give up, it doesn't matter. If the maintaner wants to update, it'll eventually update it.
Comment 3 Val Packett 2022-01-22 16:31:35 UTC
"I give up" is not really "Overcome By Events". And 11 days is really not a long time.

If you would like to become the maintainer, go ahead :)

What's with the CPE_VENDOR=libretro deletion?
Comment 4 Daniel Menelkir 2022-01-25 18:16:06 UTC
(In reply to Greg V from comment #3)
That wasn't the only reason, sorry for that. I just gave up entirely because some other reasons I prefer not expose here. So I'm safe of the opportunity.
Comment 5 Daniel Menelkir 2022-01-25 18:36:45 UTC
Created attachment 231331 [details]
retroarch-v2

I've updated to 1.10.0 in the meantime.
Comment 6 Daniel Menelkir 2022-01-25 18:36:59 UTC
Created attachment 231332 [details]
libretro-core-info-v1
Comment 7 Val Packett 2022-01-26 20:40:31 UTC
Created attachment 231365 [details]
0001-games-libretro-core-info-update-to-1.10.0.patch

Missed new files in core-info (here's my version), retroarch itself LGTM
Comment 8 Val Packett 2022-01-26 20:42:27 UTC
Created attachment 231366 [details]
0001-games-retroarch-update-to-1.10.0.patch

(for consistency, retroarch as a format-patch with my author info etc.)
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-27 11:34:07 UTC
Resuming the work in the PR
Comment 10 commit-hook freebsd_committer freebsd_triage 2022-01-30 16:43:56 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cf87b68f594f71db1ea49d9ac3c1a28a430b5456

commit cf87b68f594f71db1ea49d9ac3c1a28a430b5456
Author:     Greg V <greg@unrelenting.technology>
AuthorDate: 2022-01-27 11:36:52 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-01-30 16:41:46 +0000

    games/{lib}retro{arch,-core-info}: update to 1.10.0

    ChangeLog: https://github.com/libretro/RetroArch/blob/master/CHANGES.md

    PR:     261093
    Reported by:    menelkir@itroll.org

 games/libretro-core-info/Makefile  |  2 +-
 games/libretro-core-info/distinfo  |  6 +++---
 games/libretro-core-info/pkg-plist |  5 +++++
 games/retroarch/Makefile           | 33 ++++++++++++++++-----------------
 games/retroarch/distinfo           |  8 +++-----
 5 files changed, 28 insertions(+), 26 deletions(-)
Comment 11 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-30 16:44:10 UTC
Committed,

Thanks!