Bug 261105 - comms/hamlib: Update to 4.4
Summary: comms/hamlib: Update to 4.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Diane Bruce
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-11 13:05 UTC by takefu
Modified: 2022-01-12 01:56 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (hamradio)


Attachments
hamlib-4.4.patch (7.74 KB, patch)
2022-01-11 13:05 UTC, takefu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2022-01-11 13:05:54 UTC
Created attachment 230902 [details]
hamlib-4.4.patch

The distribution tarball uses patch applied to the following master branch because the build is broken.

https://github.com/Hamlib/Hamlib/commit/baea7e8c9a30ddf051cd04deec1b715856e4ed83#diff-9df9e2c313e694cf242534e90c1187fe119fac8de7c304ae438de0736209953b.patch

The error message in build is as follows.
hamlibpy_wrap.c:48824:80: error: use of undeclared identifier 'RIG_FUNCTION_SEND_VOICE_MEM'; did you mean 'RIG_FUNCTION_SEND_MORSE'?
  SWIG_Python_SetConstant(d, "RIG_FUNCTION_SEND_VOICE_MEM",SWIG_From_int((int)(RIG_FUNCTION_SEND_VOICE_MEM)));
                                                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                                               RIG_FUNCTION_SEND_MORSE

hamlibtcl_wrap.c:45844:86: error: use of undeclared identifier 'RIG_FUNCTION_SEND_VOICE_MEM'; did you mean 'RIG_FUNCTION_SEND_MORSE'?
  SWIG_Tcl_SetConstantObj(interp, "RIG_FUNCTION_SEND_VOICE_MEM", SWIG_From_int((int)(RIG_FUNCTION_SEND_VOICE_MEM)));
                                                                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                                                     RIG_FUNCTION_SEND_MORSE
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-01-12 01:13:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=763fc7004ceaf9e837b160271f4491fbe92df031

commit 763fc7004ceaf9e837b160271f4491fbe92df031
Author:     Diane Bruce <db@FreeBSD.org>
AuthorDate: 2022-01-12 01:06:38 +0000
Commit:     Diane Bruce <db@FreeBSD.org>
CommitDate: 2022-01-12 01:06:38 +0000

    comms/hamlib:  Update to 4.4

    - Some patches not needed now due to adrian@ patches sent upstream.

    - Additional changes by @takefu added RIG_FUNC_SEND_VOICE_MEM from git

    For a complete log of changes to Hamlib, please visit:

    http://sourceforge.net/p/hamlib/code/commit_browser

    Major changes in 4.0 affecting usage
    Most rig model numbers have changed
    RIG_LEVEL_VOX has been deprecated and replaced by RIG_LEVEL_VOXDELAY
    rigctl 'f' command now returns VFO argument too
    rigctl 'y' and 'Y' command now take/show antenna argument and option.
    range_list items are undergoing changes towards a different model TBD
    RTS/DTR PTT sharing is off by default now -- use serial_share=1 option to
    enable

    PR:             ports/261105
    Reported by:    takefu@airport.gm

 comms/hamlib/Makefile                              | 14 +++++------
 comms/hamlib/distinfo                              |  6 ++---
 comms/hamlib/files/patch-configure.ac (gone)       | 11 --------
 comms/hamlib/files/patch-hamlib.pc.in              |  2 +-
 comms/hamlib/files/patch-tests_testlibusb.c (gone) | 29 ----------------------
 comms/hamlib/pkg-plist                             |  8 +++---
 6 files changed, 15 insertions(+), 55 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-01-12 01:54:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a9e3fd2a07b1a10441ccd2871ddbac73b5acdc98

commit a9e3fd2a07b1a10441ccd2871ddbac73b5acdc98
Author:     Diane Bruce <db@FreeBSD.org>
AuthorDate: 2022-01-12 01:06:38 +0000
Commit:     Diane Bruce <db@FreeBSD.org>
CommitDate: 2022-01-12 01:29:47 +0000

    comms/hamlib:  Update to 4.4

    - Some patches not needed now due to adrian@ patches sent upstream.

    - Additional changes by @takefu

    The distribution tarball uses patch applied to the following master branch because the build is broken.

    https://github.com/Hamlib/Hamlib/commit/baea7e8c9a30ddf051cd04deec1b715856e4ed83#diff-9df9e2c313e694cf242534e90c1187fe119fac8de7c304ae438de0736209953b.patch

    The error message in build is as follows.
    hamlibpy_wrap.c:48824:80: error: use of undeclared identifier 'RIG_FUNCTION_SEND_VOICE_MEM'; did you mean 'RIG_FUNCTION_SEND_MORSE'?
      SWIG_Python_SetConstant(d, "RIG_FUNCTION_SEND_VOICE_MEM",SWIG_From_int((int)(RIG_FUNCTION_SEND_VOICE_MEM)));

    For a complete log of changes to Hamlib, please visit:

    http://sourceforge.net/p/hamlib/code/commit_browser

    Major changes in 4.0 affecting usage
    Most rig model numbers have changed
    RIG_LEVEL_VOX has been deprecated and replaced by RIG_LEVEL_VOXDELAY
    rigctl 'f' command now returns VFO argument too
    rigctl 'y' and 'Y' command now take/show antenna argument and option.
    range_list items are undergoing changes towards a different model TBD
    RTS/DTR PTT sharing is off by default now -- use serial_share=1 option to
    enable

    PR:             ports/261105
    Reported by:    takefu@airport.gm

 comms/hamlib/files/patch-include_hamlib_rig.h (new) | 21 +++++++++++++++++++++
 comms/hamlib/files/patch-src_misc.c (new)           | 21 +++++++++++++++++++++
 2 files changed, 42 insertions(+)