Bug 261222 - x11-fonts/comic-neue: Use upstream release archive
Summary: x11-fonts/comic-neue: Use upstream release archive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-15 10:53 UTC by Daniel Engberg
Modified: 2022-01-19 07:53 UTC (History)
0 users

See Also:
0mp: maintainer-feedback+

Attachments
Patch for comic-neue (1.41 KB, patch)
2022-01-15 10:53 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-01-15 10:53:15 UTC 
Created attachment 231021 [details]
Patch for comic-neue

Use upstream release archive instead of USE_GITHUB as recommended by Porters Handbook
Comment 1 Mateusz Piotrowski freebsd_committer freebsd_triage 2022-01-17 10:41:42 UTC 
Does the release archive provide the license file?
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-01-17 10:50:52 UTC 
Yes, if LICENSE_FILE doesn't exist the port will fail to build :-)
Comment 3 Mateusz Piotrowski freebsd_committer freebsd_triage 2022-01-17 13:36:41 UTC 
Excellent! Thank you! Feel free to commit!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-01-19 07:53:02 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ccfcf19db869925b0eb7841ded214ca16c89b275

commit ccfcf19db869925b0eb7841ded214ca16c89b275
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-01-19 07:25:27 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-01-19 07:52:05 +0000

    x11-fonts/comic-neue: Use upstream release archive

    Use upstream release archive instead of USE_GITHUB as recommended
    by Porters Handbook

    PR:             261222
    Reviewed by:    0mp@ (maintainer)

 x11-fonts/comic-neue/Makefile | 9 +++------
 x11-fonts/comic-neue/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 9 deletions(-)