Bug 261247 - net-im/tg_owt: Needs USES=perl to build on armv7
Summary: net-im/tg_owt: Needs USES=perl to build on armv7
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2022-01-16 15:15 UTC by Robert Clausecker
Modified: 2022-08-02 22:31 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback? (glebius)
koobs: merge-quarterly?


Attachments
armv7 build failure (34.37 KB, text/plain)
2022-02-23 10:44 UTC, Robert Clausecker
no flags Details
armv7 build success (xz compressed) (79.43 KB, application/x-xz)
2022-02-23 10:55 UTC, Robert Clausecker
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-01-16 15:15:11 UTC
Perl is required to build this port on ARM.  After patching the makefile of net-im/tg_owt to read

-USES=          cmake pkgconfig xorg
+USES=          cmake pkgconfig xorg perl5
+USE_PERL5=     build

I got the port to build on armv7 FreeBSD 13 (with Poudriere).
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2022-02-22 09:22:49 UTC
maintainer timeout
Comment 2 Gleb Smirnoff freebsd_committer freebsd_triage 2022-02-22 20:00:33 UTC
I have no possibility to test on armv7. I neither object to any change that would improve the build on it nor I can sign them as reviewed. Sorry.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2022-02-22 20:07:22 UTC
(In reply to Gleb Smirnoff from comment #2)

Would it suffice if I presented you a build log from an armv7 machine with this patch applied?
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2022-02-23 03:54:16 UTC
Any ports committer is happy and able to review the change if requested.

@Reporter Can you:

- Include the full build log, compressed if necessary, of the issue (build time or otherwise) that highlights the problem when perl is not available

- explain, or obtain the information necessary to explain the nature of the arm specific dependency on perl, where its not required (apparently) for other architectures?

- test whether any other architectures are effected

- if only specific architectures are required, scope the additional perl dependency only to those architectures, and only for the targets necessary

If you need help with dependency scoping, #freebsd-ports on IRC or #ports on Discord can help

^Triage: Retain maintainer on CC and request feedback from maintainer re this comment and comment 3.
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2022-02-23 10:44:31 UTC
Created attachment 232037 [details]
armv7 build failure

See attached build log for an example where it fails on ARM.

Perl is required on ARM only to (work/tg_owt-*/cmake/libvpx.cmake):

# Convert the ASM files from the ARM Developer Suite 1.0.1 syntax to syntax
# accepted by the platform's native assembler (e.g. GNU as from binutils).

It would be possible to make the Perl dependency an ARM-only dependency,
but it's a bit tricky.  To access the ARCH macro you have to include
bsd.port.pre.mk, but after having included that one, it is no longer
possible to add new USES.  So either a hack is needed, or Perl has to be
unconditionally included (which does not seem to be too bad).
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2022-02-23 10:55:14 UTC
Created attachment 232038 [details]
armv7 build success (xz compressed)

Attached is a log with the Perl change applied.  The build succeeds.
Comment 7 Gleb Smirnoff freebsd_committer freebsd_triage 2022-02-23 16:43:22 UTC
Kubilay, thanks! Yes, I don't mind if any port committer fixes the issue. I agree that patch should affect only the architecture(s) that indeed require perl.
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2022-04-12 14:16:49 UTC
Any progress on this one?  Again, patching in a Perl dependency just for armv7 is tricky and I would strongly prefer not to do that as it impedes maintainability.  Dear maintainer, please make a decision.
Comment 9 Robert Clausecker freebsd_committer freebsd_triage 2022-08-02 22:31:36 UTC
It appears that this is no longer needed with tg_owt-0.0.20220508.