Bug 261281 - math/octave: switch to Qhull8
Summary: math/octave: switch to Qhull8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-17 16:37 UTC by Thierry Thomas
Modified: 2022-02-18 18:49 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (stephen)

Attachments
Switch to Qhull8 (36.46 KB, patch)
2022-01-17 16:37 UTC, Thierry Thomas 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas freebsd_committer freebsd_triage 2022-01-17 16:37:19 UTC 
Created attachment 231084 [details]
Switch to Qhull8

Patch obtained from https://savannah.gnu.org/bugs/download.php?file_id=51705
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2022-01-17 16:41:07 UTC 
Several PRs have been submitted for the consumers, and these different ports should be committed at the same time, to avoid conflicts. See PR 261278, PR 261279, PR 261280, PR 261281, PR 261282 and PR 261283.
Comment 2 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2022-01-17 18:16:48 UTC 
Since all of these should be committed at the same time, it makes sense that one person is in charge of them all.  I give you permission to make this change to math/octave.
Comment 3 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2022-01-17 18:30:14 UTC 
Also, when you are done with all these commits, you may as well get rid of qhull, and rename qhull8 to qhull.
Comment 4 Thierry Thomas freebsd_committer freebsd_triage 2022-01-17 19:01:18 UTC 
(In reply to Stephen Montgomery-Smith from comment #2)
OK, thanks Stephen, I take it.
Comment 5 Thierry Thomas freebsd_committer freebsd_triage 2022-01-17 19:03:33 UTC 
(In reply to Stephen Montgomery-Smith from comment #3)
Let's do that in a second time, after a period of deprecation: maybe some people still use Qhull 7.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-02-18 18:45:41 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f1ef83b857f555f0c7a6182ca02002b63cfe80f9

commit f1ef83b857f555f0c7a6182ca02002b63cfe80f9
Author:     Thierry Thomas <thierry@FreeBSD.org>
AuthorDate: 2022-02-18 18:36:53 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2022-02-18 18:44:54 +0000

    math/octave: switch to Qhull8

    Patch obtained from https://savannah.gnu.org/bugs/download.php?file_id=51705

    PR:             261281
    Approved by:    stephen (maintainer)

 math/octave/Makefile                               |   9 +-
 math/octave/files/patch-Makefile.in (new)          |  54 +++
 math/octave/files/patch-config.in.h (new)          |  43 ++
 math/octave/files/patch-configure                  | 448 ++++++++++++++++++++-
 ...tch-libinterp_dldfcn_____delaunayn____.cc (new) |  73 ++++
 ...patch-libinterp_dldfcn_____voronoi____.cc (new) | 100 +++++
 .../patch-libinterp_dldfcn_convhulln.cc (new)      | 139 +++++++
 .../files/patch-libinterp_dldfcn_oct-qhull.h (new) |  47 +++
 .../patch-scripts_pkg_private_configure__make.m    |   4 +-
 9 files changed, 898 insertions(+), 19 deletions(-)
Comment 7 Thierry Thomas freebsd_committer freebsd_triage 2022-02-18 18:49:12 UTC 
Just committed, thanks!

Now we can deprecated math/qhull and replace it by math/qhull8.