Bug 261637 - www/rubygem-gollum: Remove unused dependencies
Summary: www/rubygem-gollum: Remove unused dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dan Langille
URL:
Keywords: needs-qa
Depends on:
Blocks: 258108
  Show dependency treegraph
 
Reported: 2022-01-31 20:38 UTC by Sir l33tname
Modified: 2022-02-14 20:50 UTC (History)
4 users (show)

See Also:
koobs: maintainer-feedback? (sirl33tname)
koobs: merge-quarterly?


Attachments
www/rubygem-gollum-lib: Fix missing dependency (2.68 KB, patch)
2022-01-31 20:38 UTC, Sir l33tname
koobs: maintainer-approval? (ruby)
Details | Diff
www/rubygem-gollum: Remove unused dependency (1.04 KB, patch)
2022-01-31 20:38 UTC, Sir l33tname
sirl33tname: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sir l33tname 2022-01-31 20:38:05 UTC
Created attachment 231476 [details]
www/rubygem-gollum-lib: Fix missing dependency

Thibault Jouan reported that the www/rubygem-gollum-lib has 2 patches which is by accident. 

Also fixed the rubygem-gollum-rugged_adapter dependency which was on the main project instead of the lib. Which is probably not a real issue since nobody used the lib for something else. Sorry for that.
Comment 1 Sir l33tname 2022-01-31 20:38:57 UTC
Created attachment 231477 [details]
www/rubygem-gollum: Remove unused dependency
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2022-02-02 21:44:20 UTC
^Triage: 

 - maintainer-feedback flag (+) not required unless requested (?) first
 - Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval

   Attachment -> Details -> maintainer-approval [+]

@Reporter:

- What are the failure modes / effects, if any, currently, in latest and quarterly, for the missing dependency, and the unneeded dependency?

- Does gollum-lib pass its test suite after patching dependency version spec? [1]

- Could you confirm QA (portlint, poudriere) for these changes

[1] (s.add_dependency 'octicons', '~> 16.0')
Comment 3 Sir l33tname 2022-02-03 20:50:16 UTC
Thanks for the feedback!

> What are the failure modes / effects, if any
Does not affect quarterly i guess since the changes are new.

For latest it means you can not use www/rubygem-gollum-lib as standalone.
(I don't think that is a use-case since the lib has a very strong coupling to www/rubygem-gollum)

I broke that here:
- https://cgit.freebsd.org/ports/commit/?id=644d2ef109a340cdf0d19561117db3d9e63b52f7
- https://cgit.freebsd.org/ports/commit/?id=fef2fa5fd8a2a9e170be66133e9d535a9bc6fd4b

The default adapter changes with the update from www/rubygem-gollum-grit_adapter10 to www/rubygem-gollum-rugged_adapter and i added it to the wrong port.

> Does gollum-lib pass its test suite after patching dependency version spec? [1]
bundle exec rake test
/usr/local/bin/ruby27 -I"lib:lib:test:." /usr/ports/www/rubygem-gollum-lib/work/gollum-lib-5.1.3/vendor/ruby/2.7/gems/rake-13.0.6/lib/rake/rake_test_loader.rb  
root@freebsd:/usr/ports/www/rubygem-gollum-lib/work/gollum-lib-5.1.3 # echo $?
0

I guess yeah also i already use this in my local setup and i guess it works.



> Could you confirm QA (portlint, poudriere) for these changes
www/rubygem-gollum # portlint
WARN: Makefile: extra item placed in the *_DEPENDS section, for example, "USES".
0 fatal errors and 1 warning found.
/www/rubygem-gollum-lib # portlint 
looks fine

not sure about the first warning tried to fix it but when i move USES over the RUN_DEPENDS section i get an other warning.
Comment 4 Sir l33tname 2022-02-05 09:13:54 UTC
testport output: https://gist.github.com/fliiiix/b471365bf049465541f33ef9996fcd95
Comment 5 Dan Langille freebsd_committer freebsd_triage 2022-02-14 20:16:56 UTC
I'll take this. It's related to the ruby-gems port I also want to fix.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-02-14 20:47:03 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=14a03240db5afd2841d11f349481175901395a41

commit 14a03240db5afd2841d11f349481175901395a41
Author:     Dan Langille <dvl@FreeBSD.org>
AuthorDate: 2022-02-14 20:34:39 +0000
Commit:     Dan Langille <dvl@FreeBSD.org>
CommitDate: 2022-02-14 20:46:00 +0000

    www/rubygem-gollum: remove incorrect dependency

    www/rubygem-gollum-lib: add missing dependency

    www/rubygem-gollum was depending up on www/rubygem-gollum-rugged_adapter
    which should instead be a dependency of www/rubygem-gollum-lib

    Also, remove the patch-gemspec.rb patch on www/rubygem-gollum-lib

    PR:             261637
    Reported by:    Sir l33tname <sirl33tname@gmail.com>
    Approved by:    ruby@ (zi)

 www/rubygem-gollum-lib/Makefile                      |  4 +++-
 www/rubygem-gollum-lib/files/patch-gemspec.rb (gone) | 11 -----------
 www/rubygem-gollum/Makefile                          |  2 +-
 3 files changed, 4 insertions(+), 13 deletions(-)
Comment 7 Dan Langille freebsd_committer freebsd_triage 2022-02-14 20:50:08 UTC
Thank you.