Bug 262239 - Mk/Uses/cmake.mk: Build tests on multiple CPUs
Summary: Mk/Uses/cmake.mk: Build tests on multiple CPUs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-27 21:44 UTC by Yuri Victorovich
Modified: 2022-03-24 20:02 UTC (History)
1 user (show)

See Also:

Attachments
patch (614 bytes, patch)
2022-02-27 21:44 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2022-02-27 21:44:08 UTC 
Created attachment 232149 [details]
patch

The attached patch adds _MAKE_JOBS to the test build line.

Some testsuites are very large, and there's no reason to build them on a single CPU.
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2022-03-18 19:18:52 UTC 
lgtm
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2022-03-24 15:11:24 UTC 
(In reply to Tobias C. Berner from comment #1)

Is this patch considered to be approved?
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2022-03-24 18:53:45 UTC 
(In reply to Yuri Victorovich from comment #2)
yes :) sorry, if that was not clear.

mfg Tobias
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2022-03-24 19:02:09 UTC 
(In reply to Tobias C. Berner from comment #3)

Thanks!
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2022-03-24 20:02:40 UTC 
Committed, thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-03-24 20:02:42 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=134bd31bc6b3b26837cc1ed06d7bcc53ee9df184

commit 134bd31bc6b3b26837cc1ed06d7bcc53ee9df184
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2022-03-24 20:00:39 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-03-24 20:02:13 +0000

    Mk/Uses/cmake.mk: Build tests on multiple CPUs

    PR:             262239
    pproved by:     tcberner@ (from kde@)

 Mk/Uses/cmake.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)