Bug 262355 - net-im/dino: too many deps
Summary: net-im/dino: too many deps
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ashish SHUKLA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-05 11:05 UTC by Ivan Rozhuk
Modified: 2022-03-13 12:20 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (ashish)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2022-03-05 11:05:09 UTC
Is it really required to add pulse as dep?

https://github.com/dino/dino/blob/master/plugins/rtp/CMakeLists.txt
there is only: Gst, GstApp, GstAudio and GstRtp.

WebRTCAudioProcessing is optional dep too.


Also there is a set of RTP_ENABLE_* options that disabled by default and may be important to enable it.
Comment 1 Ashish SHUKLA freebsd_committer freebsd_triage 2022-03-05 13:13:44 UTC
> Is it really required to add pulse as dep?

Pulse is required apparently, as per:

https://github.com/dino/dino/blob/v0.3.0/plugins/rtp/src/plugin.vala#L323

> WebRTCAudioProcessing is optional dep too.

I added that to not miss anything. I'll configure it as ON by default option.

> Also there is a set of RTP_ENABLE_* options that disabled by default and may be important to enable it.

Seems like I missed enabling those RTP_ENABLE_* options :(. I'll look at that, and get back to you on that shortly.
Comment 2 Ivan Rozhuk 2022-03-05 13:23:40 UTC
> Pulse is required apparently, as per

https://github.com/dino/dino/blob/v0.3.0/plugins/rtp/src/plugin.vala#L334

as for me this looks like it can support non pulse sound devices.

And next function by same logic must require pipewire to support video.
Comment 3 Ivan Rozhuk 2022-03-05 13:25:11 UTC
I mean code prefer pulse and pipewire devices, but if there is not such devices code will return all other founded devices.
Comment 4 Ashish SHUKLA freebsd_committer freebsd_triage 2022-03-05 18:43:36 UTC
I was not able to get it to show up my OSS devices with pulseaudio uninstalled which is how/why I added dependency on pulseaudio.

If you're able to get it working without pulseaudio, then I'm happy to add an OPTION for it.

As for video, v4l2 (with webcamd) works fine, so I didn't even look at enabling/adding pipewire.
Comment 5 Ivan Rozhuk 2022-03-05 22:22:30 UTC
Looks like this is gsreammer issue:
https://github.com/dino/dino/blob/master/plugins/rtp/src/plugin.vala#L45

I remember how bad it work in xfce4-mixer.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-03-13 12:20:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=094ff862382121804f1cbad8f2d2f4e5b47387f0

commit 094ff862382121804f1cbad8f2d2f4e5b47387f0
Author:     Ashish SHUKLA <ashish@FreeBSD.org>
AuthorDate: 2022-03-13 12:19:24 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2022-03-13 12:19:24 +0000

    net-im/dino: Add missed options related to RTP

    PR:             262355
    Reported by:    Ivan Rozhuk <rozhuk dot im at gmail dot com>

 net-im/dino/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)