Bug 262366 - multimedia/streamlink: Update to 5.5.1
Summary: multimedia/streamlink: Update to 5.5.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Andree
URL:
Keywords: needs-qa
Depends on: 262398 262399 264406
Blocks:
  Show dependency treegraph
 
Reported: 2022-03-05 17:14 UTC by Naram Qashat
Modified: 2023-05-13 17:07 UTC (History)
7 users (show)

See Also:
takefu: maintainer-feedback+


Attachments
py-streamlink-3.2.0.patch (4.47 KB, patch)
2022-03-08 01:06 UTC, takefu
takefu: maintainer-approval+
Details | Diff
Update streamlink to 3.2.0, fix test and change PORTVERSION to DISTVERSION (4.88 KB, patch)
2022-03-08 23:25 UTC, Niclas
no flags Details | Diff
py-streamlink-4.1.0.patch (4.44 KB, patch)
2022-06-02 02:30 UTC, takefu
takefu: maintainer-approval+
Details | Diff
py-streamlink-5.5.1.patch (5.00 KB, patch)
2023-05-10 05:42 UTC, takefu
takefu: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2022-03-05 17:14:32 UTC
multimedia/streamlink should be updated to the latest version, 3.1.1. I would've provided a patch but I currently am not in a position to do so, although I feel it should be a trivial update as it probably just requires changing PORTVERSION and regenerating distinfo.

Although, from looking at https://github.com/streamlink/streamlink/blob/3.1.1/setup.cfg it might also need to have a dependency on devel/ly-lxml added? I am not sure about this currently.

For reference, these are the changelogs since 2.1.2 (which is the version the port is at currently):

https://github.com/streamlink/streamlink/releases/tag/3.1.1
https://github.com/streamlink/streamlink/releases/tag/3.1.0
https://github.com/streamlink/streamlink/releases/tag/3.0.3
https://github.com/streamlink/streamlink/releases/tag/3.0.2
https://github.com/streamlink/streamlink/releases/tag/3.0.1
https://github.com/streamlink/streamlink/releases/tag/3.0.0
https://github.com/streamlink/streamlink/releases/tag/2.4.0
https://github.com/streamlink/streamlink/releases/tag/2.3.0
https://github.com/streamlink/streamlink/releases/tag/2.2.0
Comment 1 takefu 2022-03-08 01:06:32 UTC
Created attachment 232315 [details]
py-streamlink-3.2.0.patch

Update to 3.2.0

request
  bug#262398 - www/py-websocket-client: Update to 1.3.1
  bug#262399 - www/py-requests: Update to 2.27.1

Currently the test fails.
Comment 2 Niclas 2022-03-08 23:25:26 UTC
Created attachment 232331 [details]
Update streamlink to 3.2.0, fix test and change PORTVERSION to DISTVERSION

Looks like we are trying to update the same port.
Since I've already made this patch I'll post it and you can decide to use it if you want to.
Comment 3 Neel Chauhan freebsd_committer freebsd_triage 2022-03-10 17:43:04 UTC
Committed!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-03-10 17:43:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a6976a7dda52e65445ed95bd1c3cacefb9566545

commit a6976a7dda52e65445ed95bd1c3cacefb9566545
Author:     Niclas Carlsson <n_carlsson@outlook.com>
AuthorDate: 2022-03-08 22:05:46 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2022-03-10 17:42:24 +0000

    multimedia/streamlink: Update to 3.2.0

    PR:             262366
    Approved by:    maintainer

 multimedia/streamlink/Makefile  | 45 +++++++++++++++++------------------------
 multimedia/streamlink/distinfo  |  6 +++---
 multimedia/streamlink/pkg-descr | 11 +++-------
 3 files changed, 24 insertions(+), 38 deletions(-)
Comment 5 Niclas 2022-03-10 18:04:38 UTC
(In reply to Neel Chauhan from comment #3)
That's not a good idea.

www/py-requests and www/py-websocket-client need to be updated first before streamlink 3.2.0 will work.
Comment 6 Neel Chauhan freebsd_committer freebsd_triage 2022-03-10 18:08:42 UTC
Ahhh, makes sense. I reverted the patch in this commit:

https://cgit.freebsd.org/ports/commit/?id=d7277abb83fad9e3a348d158f9bf9cd79853a922

And keeping this update as "open".
Comment 7 Niclas 2022-03-10 18:16:21 UTC
Could someone add the "Depends on" to make it clear?
Comment 8 takefu 2022-06-02 02:30:21 UTC
Created attachment 234390 [details]
py-streamlink-4.1.0.patch

Update to 4.1.0

request
  bug#262399 - www/py-requests: Update to 2.27.1
  bug#264406 - [NEW PORT] devel/py-versioningit 1.1.1
Comment 9 takefu 2022-06-02 03:00:30 UTC
(In reply to takefu from comment #8)

request

  bug#262398 www/py-websocket-client: Update to 1.3.1
Comment 10 Naram Qashat 2022-12-13 20:09:52 UTC
I've asked for both the blocking bugs to be looked into, because this bug is getting quite long in the tooth, the latest version of streamlink is now at 5.1.2 so the port is very outdated.
Comment 11 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-24 14:21:08 UTC
Do this update depends on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264406 ?

I don't see a dependency on [NEW PORT] devel/py-versioningit
Comment 12 Niclas 2023-02-06 14:52:19 UTC
devel/py-versioningit is a dependency for 4.0.0 and later. But I believe all requirements for 3.2.0 are now in place. Wouldn't it be better to at least get this updated to 3.2.0 until such time that needed dependencies are in place for later versions?
Comment 13 Nuno Teixeira freebsd_committer freebsd_triage 2023-02-07 09:02:48 UTC
(In reply to Niclas from comment #12)

3.2.0 was reverted in https://cgit.freebsd.org/ports/commit/?id=d7277abb83fad9e3a348d158f9bf9cd79853a922

I could revert that revert.

I'm ok with updating it first to 3.2.0 and close this PR.
Next a new PR should be open for 4.1.0 update and put a depend on PR from new dependency.

Please tell me if everything is ok so I can revert the revert :)

Cheers
Comment 14 Nuno Teixeira freebsd_committer freebsd_triage 2023-02-10 14:16:48 UTC
Friendly ping
Comment 15 takefu 2023-05-10 05:42:40 UTC
Created attachment 242089 [details]
py-streamlink-5.5.1.patch

Update to 5.1.2

https://streamlink.github.io/changelog.html#streamlink-5-5-1-2023-05-08
Comment 16 Matthias Andree freebsd_committer freebsd_triage 2023-05-13 16:43:24 UTC
Comment on attachment 242089 [details]
py-streamlink-5.5.1.patch

renaming the file and description to match the new PORTVERSION and takefu's changelog link. will update summary again, too
Comment 17 commit-hook freebsd_committer freebsd_triage 2023-05-13 17:07:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b5f09fd13592773d34f2b656f6f88e303c786746

commit b5f09fd13592773d34f2b656f6f88e303c786746
Author:     Takefu <takefu@airport.fm>
AuthorDate: 2023-05-13 17:04:38 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2023-05-13 17:05:18 +0000

    multimedia/streamlink: maintainer update to 5.5.1

    PR:             262366

 multimedia/streamlink/Makefile  | 52 ++++++++++++++++++-----------------------
 multimedia/streamlink/distinfo  |  6 ++---
 multimedia/streamlink/pkg-descr | 10 ++++----
 3 files changed, 31 insertions(+), 37 deletions(-)