Bug 262451 - devel/vc: fix port for i386 arch
Summary: devel/vc: fix port for i386 arch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: i386 Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-09 19:43 UTC by Max Brazhnikov
Modified: 2022-03-09 21:46 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
patch (1.42 KB, patch)
2022-03-09 19:43 UTC, Max Brazhnikov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Brazhnikov freebsd_committer freebsd_triage 2022-03-09 19:43:44 UTC 
Created attachment 232354 [details]
patch

vc library is no-op on i386 right now, e.g. krita fails to build:

https://people.freebsd.org/~makc/logs/krita-5.0.2.log

The reason is that cmake sets CMAKE_SYSTEM_PROCESSOR to i386, while vc demands i686. This patch relaxes check for cpu type and fixes krita. I'm not sure if this a proper fix, perhaps the port should force CMAKE_SYSTEM_PROCESSOR to i686.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2022-03-09 21:45:16 UTC 
Committed, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-03-09 21:46:07 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7daf4cb58771b277916af8dbfe08b3241f49af11

commit 7daf4cb58771b277916af8dbfe08b3241f49af11
Author:     Max Brazhnikov <makc@FreeBSD.org>
AuthorDate: 2022-03-09 21:43:23 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-03-09 21:45:16 +0000

    devel/vc: fix port for i386 arch

    PR:             262451

 devel/vc/Makefile                         |  1 +
 devel/vc/files/patch-CMakeLists.txt (new) | 11 +++++++++++
 2 files changed, 12 insertions(+)