Bug 262736 - x11-toolkits/vte3: fail to build "meson.build:159:2: ERROR: Assert failed: needs clang++ >= 11.0 for gnu++20 support"
Summary: x11-toolkits/vte3: fail to build "meson.build:159:2: ERROR: Assert failed: ne...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-23 10:37 UTC by Vladimir Druzenko
Modified: 2022-03-23 19:22 UTC (History)
3 users (show)

See Also:
nc: maintainer-feedback+
vvd: maintainer-feedback?

Attachments
unbreak 12.3 with llvm < 11 (656 bytes, patch)
2022-03-23 19:03 UTC, Vladimir Druzenko 		no flags Details | Diff
unbreak 12.3 with llvm < 11 (v2) (656 bytes, patch)
2022-03-23 19:22 UTC, Vladimir Druzenko 		vvd: maintainer-approval?
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2022-03-23 10:37:37 UTC 
12.3-p4 amd64.

===>  Configuring for vte3-0.66.2
The Meson build system
Version: 0.61.2
Source dir: /tmp/work/usr/ports/x11-toolkits/vte3/work/vte-0.66.2
Build dir: /tmp/work/usr/ports/x11-toolkits/vte3/work/vte-0.66.2/_build
Build type: native build
Project name: vte
Project version: 0.66.2
C compiler for the host machine: cc (clang 10.0.1 "FreeBSD clang version 10.0.1 (git@github.com:llvm/llvm-project.git llvmorg-10.0.1-0-gef32c611aa2)")
C linker for the host machine: cc ld.lld 10.0.1
C++ compiler for the host machine: c++ (clang 10.0.1 "FreeBSD clang version 10.0.1 (git@github.com:llvm/llvm-project.git llvmorg-10.0.1-0-gef32c611aa2)")
C++ linker for the host machine: c++ ld.lld 10.0.1
Host machine cpu family: x86_64
Host machine cpu: x86_64
Compiler for C supports arguments -std=gnu11: YES
meson.build:137: WARNING: Consider using the built-in option for language standard version instead of using "-std=gnu11".
Compiler for C++ supports arguments -std=gnu++20: YES
meson.build:145: WARNING: Consider using the built-in option for language standard version instead of using "-std=gnu++20".

meson.build:159:2: ERROR: Assert failed: needs clang++ >= 11.0 for gnu++20 support

A full log can be found at /tmp/work/usr/ports/x11-toolkits/vte3/work/vte-0.66.2/_build/meson-logs/meson-log.txt
Comment 1 Neel Chauhan freebsd_committer freebsd_triage 2022-03-23 16:14:19 UTC 
I fixed it in this commit: https://cgit.freebsd.org/ports/commit/?id=e864e9b815f240b77fa8e1a71124222de0c7b725

If you still have issues, feel free to reopen.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2022-03-23 18:07:08 UTC 
> LLVM_VERSION=	11
This doesn't work.

Trying make patch.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2022-03-23 19:03:43 UTC 
Created attachment 232663 [details]
unbreak 12.3 with llvm < 11

Tested on 12.3 amd64 and with LLVM_DEFAULT=13.
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2022-03-23 19:04:12 UTC 
Open.
Comment 5 Neel Chauhan freebsd_committer freebsd_triage 2022-03-23 19:07:31 UTC 
Thanks for the patch! It's committed!

I have been busy with updating GNOME to 42, so sorry for breaking vte3.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-03-23 19:07:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b4173875e5eff5fa5aa35f93e4af82f2695947a4

commit b4173875e5eff5fa5aa35f93e4af82f2695947a4
Author:     VVD <vvd@unislabs.com>
AuthorDate: 2022-03-23 19:06:13 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2022-03-23 19:06:13 +0000

    x11-toolkits/vte3: Unbreak 12.3 with LLVM < 11

    PR:     262736

 x11-toolkits/vte3/Makefile | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2022-03-23 19:22:34 UTC 
Created attachment 232665 [details]
unbreak 12.3 with llvm < 11 (v2)

Corrected __FreeBSD_version from https://docs.freebsd.org/en/books/porters-handbook/book/#versions