Bug 262997 - [NEW PORT] devel/oci-cli: command line tools for Oracle Cloud Infrastructure
Summary: [NEW PORT] devel/oci-cli: command line tools for Oracle Cloud Infrastructure
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joseph Mingrone
URL: https://github.com/oracle/oci-cli
Keywords:
Depends on: 262985
Blocks:
  Show dependency treegraph
 
Reported: 2022-04-02 06:59 UTC by Alessandro Sagratini
Modified: 2022-06-02 19:36 UTC (History)
3 users (show)

See Also:


Attachments
make describe (663 bytes, text/plain)
2022-04-02 07:00 UTC, Alessandro Sagratini
no flags Details
shar file (3.73 KB, text/plain)
2022-04-02 07:00 UTC, Alessandro Sagratini
no flags Details
port test (138.70 KB, application/x-bzip2)
2022-04-02 07:01 UTC, Alessandro Sagratini
no flags Details
portlint (12 bytes, text/plain)
2022-04-02 07:02 UTC, Alessandro Sagratini
no flags Details
poudriere (143.09 KB, application/x-bzip2)
2022-04-02 07:02 UTC, Alessandro Sagratini
no flags Details
example output (54.11 KB, text/plain)
2022-04-02 19:30 UTC, Alessandro Sagratini
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alessandro Sagratini 2022-04-02 06:59:47 UTC
Hello,
I am proposing to add oci-cli to the ports tree as it might be useful to a few user.

I am also attaching log files that were created during port testing [1]

[1] https://docs.freebsd.org/en/books/porters-handbook/testing/
Comment 1 Alessandro Sagratini 2022-04-02 07:00:18 UTC
Created attachment 232883 [details]
make describe
Comment 2 Alessandro Sagratini 2022-04-02 07:00:35 UTC
Created attachment 232884 [details]
shar file
Comment 3 Alessandro Sagratini 2022-04-02 07:01:56 UTC
Created attachment 232885 [details]
port test
Comment 4 Alessandro Sagratini 2022-04-02 07:02:23 UTC
Created attachment 232886 [details]
portlint
Comment 5 Alessandro Sagratini 2022-04-02 07:02:41 UTC
Created attachment 232887 [details]
poudriere
Comment 6 Joseph Mingrone freebsd_committer freebsd_triage 2022-04-02 18:16:27 UTC
You have

USE_PYTHON=autoplist concurrent distutils noflavors

I don't think noflavors is useful here. distutils implies flavors, which creates a flavor for the default versions of python2 and python3.  This port is python3 only, so there is only ever one flavor.  A similar argument could be made for concurrent, but there could be situations where changes to DEFAULT_VERSIONS could result in e.g., both oci-cli-py38 and oci-cli-py39 being installed, so lets leave it.

I think we also want PKGNAMEPREFIX=${PYTHON_PKGNAMEPREFIX}.

No need to submit an updated patch/shar.  Just let me know whether I'm missing some valid reason for your choices.  If not, we can proceed.

Oh, did you run-time test this?
Comment 7 Alessandro Sagratini 2022-04-02 18:33:20 UTC
"Oh, did you run-time test this?"
Yes, and it works.

@Joseph Mingrone
Comment 8 Alessandro Sagratini 2022-04-02 19:30:16 UTC
Created attachment 232906 [details]
example output
Comment 9 Alessandro Sagratini 2022-04-02 19:31:08 UTC
I am attaching an example output to confirm everything is working when package is installed.
Comment 10 commit-hook freebsd_committer freebsd_triage 2022-04-02 19:31:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=28504b62bfab211394387d5c5e7ca2135a714a58

commit 28504b62bfab211394387d5c5e7ca2135a714a58
Author:     Joseph Mingrone <jrm@FreeBSD.org>
AuthorDate: 2022-04-02 19:29:00 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2022-04-02 19:29:51 +0000

    devel/oci-cli: New port for Oracle Cloud CLI

    WWW: https://github.com/oracle/oci-cli/

    PR:             262997 (with modification)

    Sponsored by:   The FreeBSD Foundation
    Submitted by:   Alessandro Sagratini <ale_sagra@hotmail.com>

 devel/Makefile                           |  1 +
 devel/oci-cli/Makefile (new)             | 36 ++++++++++++++++++++++++++++++++
 devel/oci-cli/distinfo (new)             |  3 +++
 devel/oci-cli/files/patch-setup.py (new) | 23 ++++++++++++++++++++
 devel/oci-cli/pkg-descr (new)            |  4 ++++
 5 files changed, 67 insertions(+)
Comment 11 Joseph Mingrone freebsd_committer freebsd_triage 2022-04-02 19:42:54 UTC
Thank you.  Please re-open if there are any problems.
Comment 12 commit-hook freebsd_committer freebsd_triage 2022-06-02 19:36:39 UTC
A commit in branch 2022Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c1944bd93df312c287d2466c65ee3cb56af7c2bd

commit c1944bd93df312c287d2466c65ee3cb56af7c2bd
Author:     Joseph Mingrone <jrm@FreeBSD.org>
AuthorDate: 2022-04-02 19:29:00 +0000
Commit:     Dave Cottlehuber <dch@FreeBSD.org>
CommitDate: 2022-06-02 19:30:40 +0000

    devel/oci-cli: New port for Oracle Cloud CLI

    WWW: https://github.com/oracle/oci-cli/

    PR:             262997 (with modification)

    Sponsored by:   The FreeBSD Foundation
    Submitted by:   Alessandro Sagratini <ale_sagra@hotmail.com>

    (cherry picked from commit 28504b62bfab211394387d5c5e7ca2135a714a58)

 devel/Makefile                           |  1 +
 devel/oci-cli/Makefile (new)             | 36 ++++++++++++++++++++++++++++++++
 devel/oci-cli/distinfo (new)             |  3 +++
 devel/oci-cli/files/patch-setup.py (new) | 23 ++++++++++++++++++++
 devel/oci-cli/pkg-descr (new)            |  4 ++++
 5 files changed, 67 insertions(+)