Bug 263203 - math/ocamlgsl: upgrade to 1.24.3
Summary: math/ocamlgsl: upgrade to 1.24.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks: 262781
  Show dependency tree / graph
 
Reported: 2022-04-10 18:21 UTC by Thierry Thomas
Modified: 2024-06-02 17:45 UTC (History)
3 users (show)

See Also:
madpilot: maintainer-feedback-

Attachments
Upgrade to 1.24.3 and link with openblas (45.04 KB, patch)
2022-04-10 18:21 UTC, Thierry Thomas 		no flags Details | Diff
0001-math-ocamlgsl-Update-to-1.25.0-and-link-with-openbla.patch (44.97 KB, patch)
2024-06-02 10:57 UTC, Benjamin Jacobs 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas freebsd_committer freebsd_triage 2022-04-10 18:21:06 UTC 
Created attachment 233130 [details]
Upgrade to 1.24.3 and link with openblas

Upgrade to 1.24.3, in order to fix the failure reported in PR 262781 with a recent OCaml for math/orpie.

Since I'm there, also link with openblas.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2024-05-22 17:21:13 UTC 
Hi,

I've just committed another big update to ocaml and reset maintainership on this one.

Are you interested in committing this? It has also long timed out.

If you're not interested in doing this youreself, I can take a look at committing this patch.

Thanks in advance!
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2024-05-23 19:23:30 UTC 
Take on submitter request.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2024-05-29 09:56:45 UTC 
I just noticed this has a dependency on ocaml-dune-configurator, but there is no such thing in the ports tree.

DO you happen to have it locally?
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2024-05-29 10:33:28 UTC 
(In reply to Guido Falsi from comment #3)

Found in bug #262784

This will require more work than expected.
Comment 5 Benjamin Jacobs 2024-06-02 00:59:52 UTC 
dune-configurator is provided by devel/ocaml-dune already.
I can take this bug.
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2024-06-02 07:21:04 UTC 
(In reply to Benjamin Jacobs from comment #5)

Great, you could update the patch so it uses dune-configurator provided by devel/ocaml-dune?

The I'd be able to commit it.
Comment 7 Benjamin Jacobs 2024-06-02 10:57:50 UTC 
Created attachment 251154 [details]
0001-math-ocamlgsl-Update-to-1.25.0-and-link-with-openbla.patch

New patch: changed WWW, added LICENSE_FILE, added EXAMPLES option, aligned stublibs directory, and stripped shared libraries.

Tested on the main 4.14.2 tree, and on a 5.2.0 WIP branch.
Comment 8 Guido Falsi freebsd_committer freebsd_triage 2024-06-02 13:33:52 UTC 
(In reply to Benjamin Jacobs from comment #7)

Thanks a lot, going to look at this shortly.
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-06-02 17:35:44 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=294c02c89b2c15b19b7e802b820a6fb421ad2fbe

commit 294c02c89b2c15b19b7e802b820a6fb421ad2fbe
Author:     Benjamin Jacobs <freebsd@dev.thsi.be>
AuthorDate: 2024-06-02 17:33:19 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2024-06-02 17:33:19 +0000

    math/ocamlgsl: Update to 1.25.0

    - While here cleanup and update Makefile

    First version of the patch provided by thierry@.

    PR:             263203

 math/ocamlgsl/Makefile                    |  61 ++-
 math/ocamlgsl/distinfo                    |   6 +-
 math/ocamlgsl/files/patch-setup.ml (gone) |  20 -
 math/ocamlgsl/pkg-plist                   | 871 +++++++++++-------------------
 4 files changed, 342 insertions(+), 616 deletions(-)
Comment 10 Guido Falsi freebsd_committer freebsd_triage 2024-06-02 17:36:24 UTC 
Update committed.
Comment 11 Thierry Thomas freebsd_committer freebsd_triage 2024-06-02 17:45:36 UTC 
Great!