Bug 263532 - lang/ypsilon: Switch from USE_GCC to USE_BINUTILS
Summary: lang/ypsilon: Switch from USE_GCC to USE_BINUTILS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Lorenzo Salvadore
URL: http://package18.nyi.freebsd.org/data...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-24 19:14 UTC by Lorenzo Salvadore
Modified: 2022-05-27 10:23 UTC (History)
3 users (show)

See Also:
vmagerya: maintainer-feedback+


Attachments
ypsilon update to 2.0.8 (1.60 KB, patch)
2022-05-21 17:35 UTC, Lorenzo Salvadore
no flags Details | Diff
lang_ypsilon_switch_to_USE_BINUTILS (843 bytes, patch)
2022-05-27 10:01 UTC, Lorenzo Salvadore
vmagerya: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore freebsd_committer freebsd_triage 2022-04-24 19:14:59 UTC
Building port with GCC 11 gives the following error message (full log in URL):

/usr/local/bin/ld: s_current_vm: TLS definition in main.o section .tbss mismatches non-TLS reference in interpreter.o
/usr/local/bin/ld: interpreter.o: error adding symbols: bad value
collect2: error: ld returned 1 exit status
Comment 1 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-05-21 17:35:55 UTC
Created attachment 234084 [details]
ypsilon update to 2.0.8

This patch should fix the build.

Apparently, USE_GCC is not needed, at least after the update: USE_BINUTILS is enough to build.

Patch tested successfully on {i386, amd64} {12.1,13.0,13.1}-RELEASE.
Comment 2 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-05-21 17:47:33 UTC
Actually, I must have made something wrong with my testing: I have just tested it again and the port already builds successfully with GCC 11 without any change.

Still, it is nice to update it and to switch form USE_GCC to USE_BINUTILS, so I still submit the patch, but I also change the summary of the bug and I remove the block to the GCC default version update.
Comment 3 Gerald Pfeifer freebsd_committer freebsd_triage 2022-05-26 19:11:37 UTC
Approved with my mentor (for Lorenzo) hat.

It would be nice/preferable to  hear from the maintainer, but timeout
is an option, too.
Comment 4 Vitaly Magerya 2022-05-27 07:44:29 UTC
As far as I can see the proposed update changes PORTVERSION but not GH_TUPLE, so the actual version is still 0.9.6.3, and the tarball has the same hash. I think the PORTVERSION update is a mistake here. An actual update to 2.x would require adding LLVM as a dependency, and some more testing.

I'm not against just the change from USE_GCC to USE_BINUTILS if that's enough to build it (does it build with current clang?).
Comment 5 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-05-27 09:32:33 UTC
(In reply to Vitaly Magerya from comment #4)

Thank you very much for your revision. Indeed, you are completely right, I should have been more careful with this patch.

I am going to submit a new patch soon that will include the switch from USE_GCC to USE_BINUTILS and, if it works, the actual update.
Comment 6 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-05-27 10:01:47 UTC
Created attachment 234258 [details]
lang_ypsilon_switch_to_USE_BINUTILS

Here it is.

The patch only includes the switch from USE_GCC to USE_BINUTILS and was tested successfully with poudriere on {i386,amd64} {12.3,13.0,13.1}-RELEASE. I tried to make an update too, but the patches have to be recreated: it might be an easy thing, but I lack the time to do it, so I submit to your approval only that switch.

Thanks.
Comment 7 Vitaly Magerya 2022-05-27 10:05:01 UTC
Comment on attachment 234258 [details]
lang_ypsilon_switch_to_USE_BINUTILS

Looks good to me.
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-05-27 10:22:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6ed8b389ba2acf8ff3f39c7a9359db873dafb1f1

commit 6ed8b389ba2acf8ff3f39c7a9359db873dafb1f1
Author:     Lorenzo Salvadore <salvadore@FreeBSD.org>
AuthorDate: 2022-05-27 09:52:53 +0000
Commit:     Lorenzo Salvadore <salvadore@FreeBSD.org>
CommitDate: 2022-05-27 10:21:50 +0000

    lang/ypsilon: Switch from USE_GCC to USE_BINUTILS

    PR:             263532
    Approved by:    Vitaly Magerya <vmagerya@gmail.com> (maintainer)
    Approved by:    gerald (mentor)

 lang/ypsilon/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 9 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-05-27 10:23:49 UTC
Committed, thanks again.