Bug 263546 - sysutils/uefi-edk2-qemu: Build fails with GCC 11 (both flavors)
Summary: sysutils/uefi-edk2-qemu: Build fails with GCC 11 (both flavors)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Rebecca Cran
URL: http://package22.nyi.freebsd.org/data...
Keywords:
Depends on:
Blocks: 258378
  Show dependency tree / graph
 
Reported: 2022-04-24 22:49 UTC by Lorenzo Salvadore
Modified: 2022-06-07 00:34 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (bcran)

Attachments
uefi-edk2-qemu - require gcc10 (817 bytes, patch)
2022-06-06 22:36 UTC, Lorenzo Salvadore 		salvadore: maintainer-approval? (bcran)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore freebsd_committer freebsd_triage 2022-04-24 22:49:00 UTC 
Updating GCC_DEFAULT from GCC 10 to GCC 11 is blocked by the fact that building this port with GCC 11 fails. Please see the logs at the following urls:

http://package18.nyi.freebsd.org/data/122amd64-default-foo/2021-09-18_18h41m21s/logs/errors/uefi-edk2-qemu-i386-g20191122.log
http://package18.nyi.freebsd.org/data/122amd64-default-foo/2021-09-18_18h41m21s/logs/errors/uefi-edk2-qemu-x86_64-g20191122.log

Also, it should be checked if USE_GCC is still needed and that the default clang compiler can't be used instead.
Comment 1 Rebecca Cran freebsd_committer freebsd_triage 2022-04-25 01:32:44 UTC 
I'll submit the review to update the port later today.
Comment 2 Rebecca Cran freebsd_committer freebsd_triage 2022-04-27 15:21:52 UTC 
I've submitted https://reviews.freebsd.org/D35053
Comment 3 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-05-31 10:02:10 UTC 
A new exp-run has been done and the port is still reported to be broken, both on amd64 and i386.

Here are the new logs:
http://package22.nyi.freebsd.org/data/130amd64-default-foo/2022-05-26_19h07m28s/logs/uefi-edk2-qemu-x86_64-g20191122.log
http://package22.nyi.freebsd.org/data/130amd64-default-foo/2022-05-26_19h07m28s/logs/uefi-edk2-qemu-i386-g20191122.log

In case fixing is complicate, please consider adding USE_GCC=10 to the port.
Comment 4 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-06-06 22:36:31 UTC 
Created attachment 234508 [details]
uefi-edk2-qemu - require gcc10

I propose a patch to require GCC 10. Please approve the patch at least as a temporary fix so that the GCC default version update can go forward.
Comment 5 Rebecca Cran freebsd_committer freebsd_triage 2022-06-06 23:24:02 UTC 
I'm about to commit https://reviews.freebsd.org/D35408 as the fix.
Comment 6 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-06-06 23:28:13 UTC 
(In reply to Rebecca Cran from comment #5)

Great, thank you very much.
Comment 7 Rebecca Cran freebsd_committer freebsd_triage 2022-06-06 23:39:16 UTC 
Sorry for the extreme slowness of this fix. I've just committed the deletion of sysutils/uefi-edk2-qemu and the addition of sysutils/edk2@qemu_x64 and sysutils/edk2@qemu_i386 .
Comment 8 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-06-07 00:34:13 UTC 
(In reply to Rebecca Cran from comment #7)

Thanks, and don't worry for the slowness: those ports are complex and your hard work is much appreciated.

Link to the commit:
https://cgit.freebsd.org/ports/commit/?id=177204e3190b7e608f39df4160217aad578ab7ef