Bug 263854 - multimedia/vlc broken, when UPNP is enabled
Summary: multimedia/vlc broken, when UPNP is enabled
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-multimedia (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-07 22:16 UTC by Mikhail T.
Modified: 2022-05-07 23:42 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (multimedia)


Attachments
Use UpnpInit2 regardless of IPV6 (520 bytes, patch)
2022-05-07 23:40 UTC, Mikhail T.
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail T. 2022-05-07 22:16:49 UTC
I wish, Bug 260617 was addressed, then this problem would've been caught by the build-cluster :-(

The port currently breaks with UPNP option enabled:

services_discovery/upnp.cpp:1718:21: error: use of undeclared identifier 'UpnpInit'; did you mean 'UpnpInit2'?
        int i_res = UpnpInit( psz_hostip, 0 );
                    ^~~~~~~~
                    UpnpInit2
/usr/local/include/upnp/upnp.h:545:17: note: 'UpnpInit2' declared here
EXPORT_SPEC int UpnpInit2(
Comment 1 Mikhail T. 2022-05-07 23:40:15 UTC
Created attachment 233802 [details]
Use UpnpInit2 regardless of IPV6

Ok, the problem stems from my NOT having the WITHOUT_INET6 set. The code in the upstream version of upnp.cpp incorrectly ties usage of UpnpInit2 vs. the old UpnpInit to UPNP_ENABLE_IPV6.

The attached patch turns it on, when UPNP_VERSION >= 10803 too. This should be communicated upstream, I suppose...
Comment 2 Mikhail T. 2022-05-07 23:42:19 UTC
> my NOT having the WITHOUT_INET6

Grrrrr, the double negatives :) From my YES having the WITHOUT_INET6 -- my whole world (and ports) are built without IPv6, because my ISP does not offer it.