Bug 263876 - security/gopass: Update to 1.14.1, switch to GO_MODULE
Summary: security/gopass: Update to 1.14.1, switch to GO_MODULE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/gopasspw/gopass/re...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-09 11:27 UTC by Dmitri Goutnik
Modified: 2022-05-11 06:29 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (eduardo)


Attachments
gopass-1.14.1.diff (16.35 KB, patch)
2022-05-09 11:27 UTC, Dmitri Goutnik
eduardo: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer 2022-05-09 11:27:10 UTC
Created attachment 233820 [details]
gopass-1.14.1.diff

Builds OK in poudriere; needs ports tree at or after ports 6e236e189.
Comment 1 Nuno Teixeira freebsd_committer 2022-05-10 08:04:03 UTC
Hello Dmitri!

It works like a charm, thanks a lot for your help.

Other good thing to know is that we can mix GO_MODULE with USE_GITHUB/GH_TUPLE!

2 questions:

- GO_MODULE URL: related to sysutils/gomplate why did you choose github.com/hairyhenderson/gomplate/v3 and not just github.com/hairyhenderson/gomplate ?

- USE_GITHUB=nodefault isn't documented in Porterś Handbook, where can I find more info about this "nodefault"?

Thank you very much,

Nuno Teixeira
Comment 2 Nuno Teixeira freebsd_committer 2022-05-10 08:35:41 UTC
Today I updated games/neo-cowsay with GO_MODULE=github.com/Code-Hex/Neo-cowsay/v2 just by luck because at first github.com/Code-Hex/Neo-cowsay URL fails...
Comment 3 commit-hook freebsd_committer 2022-05-10 09:34:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=aedd69e790a85d6d3ec234ed4939bd5c375a1d4c

commit aedd69e790a85d6d3ec234ed4939bd5c375a1d4c
Author:     Dmitri Goutnik <dmgk@freebsd.org>
AuthorDate: 2022-05-10 09:30:08 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-05-10 09:33:28 +0000

    security/gopass: Update to 1.14.1

     - Switch to GO_MODULE method

    ChangeLog: https://github.com/gopasspw/gopass/blob/master/CHANGELOG.md

    PR:             263876

 security/gopass/Makefile  |  62 ++-----------------------
 security/gopass/distinfo  | 116 +++-------------------------------------------
 security/gopass/pkg-plist |   5 ++
 3 files changed, 17 insertions(+), 166 deletions(-)
Comment 4 Dmitri Goutnik freebsd_committer 2022-05-10 12:55:04 UTC
(In reply to Nuno Teixeira from comment #1)
Hi Nuno,

- GO_MODULE is always taken from the upstream go.mod "module" directive [1][2]

- "nodefault" is also in the PHB [3] - in case of security/gopass, its .zip file (that is fetched from GOPROXY) is considered the "default distribution", so "nodefault" is needed for the examples repo.

[1] https://github.com/hairyhenderson/gomplate/blob/master/go.mod#L1
[2] https://docs.freebsd.org/en/books/porters-handbook/special/index.html#using-go
[3] https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github-multiple
Comment 5 Nuno Teixeira freebsd_committer 2022-05-11 06:29:14 UTC
Thanks you for the info, now I understand how it works.

Cheers,

Nuno