Bug 264214 - games/opensfx update to 1.0.3
Summary: games/opensfx update to 1.0.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/OpenTTD/OpenSFX/bl...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-25 04:25 UTC by Alastair Hogge
Modified: 2022-06-10 14:51 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (rum1cro)


Attachments
opensfx-1.0.3.patch (2.21 KB, patch)
2022-05-25 04:25 UTC, Alastair Hogge
no flags Details | Diff
opensfx-1.0.3.patch (1.94 KB, patch)
2022-05-27 02:22 UTC, Alastair Hogge
no flags Details | Diff
opensfx-1.0.3.patch (1.94 KB, patch)
2022-05-27 02:26 UTC, Alastair Hogge
no flags Details | Diff
opensfx-1.0.3.patch (2.09 KB, patch)
2022-05-27 07:12 UTC, Alastair Hogge
no flags Details | Diff
opensfx-1.0.3.patch (1.82 KB, patch)
2022-05-28 07:48 UTC, Alastair Hogge
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alastair Hogge 2022-05-25 04:25:34 UTC
Created attachment 234181 [details]
opensfx-1.0.3.patch
Comment 1 Alastair Hogge 2022-05-25 04:27:13 UTC
See also:
bug #264212
bug #264213
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2022-05-26 16:50:10 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

Q/A: PKGNAMEPREFIX before DISTNAME
Q/A: NO_ARCH before NO_BUILD

Thanks!
Comment 3 Alastair Hogge 2022-05-27 02:22:24 UTC
Created attachment 234244 [details]
opensfx-1.0.3.patch

Update patch to reflect Fernando's triage suggestions.
Comment 4 Alastair Hogge 2022-05-27 02:26:18 UTC
Created attachment 234247 [details]
opensfx-1.0.3.patch

Fix PLIST_FILES
Comment 5 Alastair Hogge 2022-05-27 07:12:51 UTC
Created attachment 234254 [details]
opensfx-1.0.3.patch

Restore .txt content as the OpenTTD in game content manager can utilise it.
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2022-05-27 09:13:43 UTC
(In reply to Alastair Hogge from comment #5)
Thanks Alastair,

The port contains now PLIST_FILES and pkg-plist. One of them should be removed. I would keep the pkg-plist.

Cheers
Comment 7 Alastair Hogge 2022-05-28 07:39:59 UTC
(In reply to Fernando Apesteguía from comment #6)
My gosh, my git-fu is incredibly lacking. I did have a patch at one stage that included the removal of pkg-plist—which I did when portlint warned about having less than 6 items in pkg-descr, and to consider using PLIST_FILES instead. Thanks for noticing this mistake.

My git flow frequently requires rm -fr ${PORTS}. I will restore the pkg-plist after a new clone of the repo. I am not sure where I am slipping up, but git will often get into a state where any files, added or removed, are ignored or completely missing.
Comment 8 Alastair Hogge 2022-05-28 07:48:57 UTC
Created attachment 234283 [details]
opensfx-1.0.3.patch

Restore pkg-plist.
Comment 9 commit-hook freebsd_committer freebsd_triage 2022-06-10 14:44:02 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4c004dea267b781a874e41ec6b956242bedbefe6

commit 4c004dea267b781a874e41ec6b956242bedbefe6
Author:     Alastair Hogge <agh@riseup.net>
AuthorDate: 2022-05-29 17:21:16 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-06-10 14:40:55 +0000

    games/opensfx: update  to 1.0.3

    ChangeLog: https://github.com/OpenTTD/OpenSFX/blob/1.0.3/docs/changelog.txt

    PR:     264214
    Reported by:    agh@riseup.net
    Approved by:    rum1cro@yandex.ru (maintainer, timeout > 2 weeks)

 games/opensfx/Makefile | 22 ++++++++++++----------
 games/opensfx/distinfo |  5 +++--
 2 files changed, 15 insertions(+), 12 deletions(-)
Comment 10 Fernando Apesteguía freebsd_committer freebsd_triage 2022-06-10 14:44:16 UTC
Committed,

Thanks!
Comment 11 Alastair Hogge 2022-06-10 14:51:18 UTC
Thanking you very muchly.