Bug 264316 - net-mgmt/prometheus2: Update to 2.33.5, switch to GO_MODULE
Summary: net-mgmt/prometheus2: Update to 2.33.5, switch to GO_MODULE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitri Goutnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-28 15:46 UTC by Dmitri Goutnik
Modified: 2022-05-30 13:56 UTC (History)
1 user (show)

See Also:
dor.bsd: maintainer-feedback+


Attachments
prometheus2-2.33.5.diff (41.79 KB, patch)
2022-05-28 15:46 UTC, Dmitri Goutnik
dor.bsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2022-05-28 15:46:01 UTC
Created attachment 234298 [details]
prometheus2-2.33.5.diff

- Update to 2.33.5, the most recent version that has assets;
- Switch to GO_MODULE, this port dependency graph seems to be too complex for modules2tuple to digest.

I didn't attempt to run it, but poudriere testport passes in 130a, 130i and 123a.
Comment 1 David O'Rourke 2022-05-30 09:21:14 UTC
Hi,

Thanks for this. I'd tried doing this upgrade myself for the 2.35.0 version, but encountered issues because proxy.golang.org appeared to be broken for that particular version, so I was waiting for 2.36.0 to be released.
It's nice to see there's a way around that breakage via the MASTER_SITES stuff.

Regarding the assets, Prometheus once again changed how those are generated, but they now provide the web-ui for each release along with the other release artifacts on GitHub. I'm hoping to use those web-ui artifacts for releases going forward just as soon as I have a successful 2.35.0+ build.

-David
Comment 2 Dmitri Goutnik freebsd_committer freebsd_triage 2022-05-30 11:19:34 UTC
(In reply to David O'Rourke from comment #1)
Hi David,

According to the Go module naming requirements, Prometheus module name is incorrect - it doesn't have v2 suffix despite Prometheus having 2.x version. Because of that, it's not listed on proxy.golang.org and we have to pull go.mod and dist archive from the Github. These hacks can be removed if/when they fix module naming.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-05-30 13:56:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=77655046bf6e8ae8067297eb2e49755b2314e1e9

commit 77655046bf6e8ae8067297eb2e49755b2314e1e9
Author:     Dmitri Goutnik <dmgk@FreeBSD.org>
AuthorDate: 2022-05-30 13:52:52 +0000
Commit:     Dmitri Goutnik <dmgk@FreeBSD.org>
CommitDate: 2022-05-30 13:52:52 +0000

    net-mgmt/prometheus2: Update to 2.33.5, switch to GO_MODULE

    Changes:        https://github.com/prometheus/prometheus/releases/tag/v2.33.5

    PR:             264316
    Approved by:    David O'Rourke <dor.bsd@xm0.uk> (maintainer)

 net-mgmt/prometheus2/Makefile                |  13 +-
 net-mgmt/prometheus2/Makefile.modules (gone) | 168 --------------
 net-mgmt/prometheus2/distinfo                | 314 +--------------------------
 3 files changed, 11 insertions(+), 484 deletions(-)
Comment 4 Dmitri Goutnik freebsd_committer freebsd_triage 2022-05-30 13:56:39 UTC
Committed, thanks!