Created attachment 234621 [details] zookeeper.patch Update to 3.8.0 Release Notes: https://zookeeper.apache.org/doc/r3.8.0/releasenotes.html Also: - Log4j2 has been updated to 2.17.2. - Log4j1.2 has been replaced to logback by the upstream (https://issues.apache.org/jira/browse/ZOOKEEPER-4427). When upgrading from before 3.8.0 these variables, if used, should be taken into account: - zookeeper_log4j_config, zookeeper_rootlogger and zookeeper_log4jpropfile are obsoleted for using with Logback. - zookeeper_logback_config is used instead zookeeper_log4j_config for Logback. - zookeeper_log4j_config is still used only for log4j-2.
(In reply to Dmitry Wagin from comment #0) Hello, You can you use pkg-message to advice users about that. It's very nice to configure. I remember to do that when I was maintainer of games/devilutionX and you can take a look at it to see an example based on a version similar to yours. https://docs.freebsd.org/en/books/porters-handbook/pkg-files/#porting-message Cheers
Created attachment 234632 [details] zookeeper.patch fixed typo in pkg-message.in
(In reply to Nuno Teixeira from comment #1) Hello, I did that. --- /dev/null +++ b/devel/zookeeper/files/pkg-message.in @@ -0,0 +1,15 @@ +[ +{ type: upgrade + maximum_version: "3.8.0" + message: <<EOM +Builtin logger framework log4j-12 has been replaced by Logback at 3.8.0 (ZOOKEEPER-4427). + +When upgrading from before 3.8.0 these variables, if used, should be taken into +account: +* zookeeper_log4j_config, zookeeper_rootlogger and zookeeper_log4jpropfile are + obsoleted for using with Logback. +* zookeeper_logback_config is used instead zookeeper_log4j_config for Logback. +* zookeeper_log4j_config is still used only for log4j-2. +EOM +} +]
(In reply to Dmitry Wagin from comment #3) Nicely done. Just for curiosity, why did you choose 'devel/zookeeper/files/pkg-message.in' and not just 'devel/zookeeper/pkg-message'?
I'll move it to pkg-message. If it is not going to be preprocessed (as in variable substitution) it should not go into an .in file.
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1dd965b53658eb14631cf41cb79f2f2037608c26 commit 1dd965b53658eb14631cf41cb79f2f2037608c26 Author: Dmitry Wagin <dmitry.wagin@ya.ru> AuthorDate: 2022-06-12 16:04:40 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-06-14 05:47:55 +0000 devel/zookeeper: Update to 3.8.0 ChangeLog: https://zookeeper.apache.org/doc/r3.8.0/releasenotes.html Add note in pkg-message on how to properly update from to 3.8.0 PR: 264616 Reported by: dmitry.wagin@ya.ru (maintainer) Reviewed by: eduardo@ devel/libzookeeper/Makefile | 2 +- devel/libzookeeper/distinfo | 6 ++--- devel/zookeeper/Makefile | 23 ++++++++--------- devel/zookeeper/distinfo | 10 +++---- devel/zookeeper/files/pkg-message (new) | 15 +++++++++++ devel/zookeeper/files/zookeeper.in | 15 +++++------ devel/zookeeper/pkg-plist | 46 ++++++++++++++++++--------------- 7 files changed, 66 insertions(+), 51 deletions(-)