Bug 264812 - New port: audio/cmusfm: Standalone last.fm and libre.fm scrobbler for cmus
Summary: New port: audio/cmusfm: Standalone last.fm and libre.fm scrobbler for cmus
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Neel Chauhan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-21 19:17 UTC by diego
Modified: 2023-12-28 10:35 UTC (History)
2 users (show)

See Also:

Attachments
Patch for audio/cmusfm (2.41 KB, patch)
2022-06-21 19:17 UTC, diego 		no flags Details | Diff
Fix build with poudriere (623 bytes, patch)
2023-03-04 09:05 UTC, Nicola Vitale 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description diego 2022-06-21 19:17:33 UTC 
Created attachment 234844 [details]
Patch for audio/cmusfm

Last.fm and libre.fm standalone scrobbler for the cmus music player.
It has a small memory footprint and has off-line played track cache
for later submission.
Comment 1 Neel Chauhan freebsd_committer freebsd_triage 2022-06-21 20:59:48 UTC 
A few comments:

 * USE_GITHUB= is defined twice

 * Your port does not build in poudriere. I get this error:

===>   cmusfm-0.4.1 depends on package: autoconf>=2.71 - found
===>   cmusfm-0.4.1 depends on package: automake>=1.16.5 - found
===>   cmusfm-0.4.1 depends on shared library: libcurl.so - found (/usr/local/lib/libcurl.so)
===>  Configuring for cmusfm-0.4.1
configure.ac:28: error: possibly undefined macro: AC_DEFINE
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:31: error: possibly undefined macro: AC_CHECK_HEADERS
autoreconf2.71: error: /usr/local/bin/autoconf2.71 failed with exit status: 1
===>  Mk/Uses/autoreconf.mk: Error running /usr/local/bin/autoreconf2.71
*** Error code 1

Stop.

It seems autoreconf is not properly used in this port.
Comment 2 Nicola Vitale freebsd_committer freebsd_triage 2023-03-04 09:05:02 UTC 
Created attachment 240580 [details]
Fix build with poudriere

pkgconfig and ssl are requirements.
Comment 3 Nicola Vitale freebsd_committer freebsd_triage 2023-03-04 09:07:10 UTC 
Comment on attachment 240580 [details]
Fix build with poudriere

I added PLIST_FILES, so pkg-plist is useless.