Bug 264917 - devel/gdcm: Use latest VTK-9 instead of ancient VTK-6; Add USES=python
Summary: devel/gdcm: Use latest VTK-9 instead of ancient VTK-6; Add USES=python
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Stephen Montgomery-Smith
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-26 21:19 UTC by Yuri Victorovich
Modified: 2022-06-26 23:10 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (stephen)

Attachments
patch (4.08 KB, patch)
2022-06-26 21:19 UTC, Yuri Victorovich 		no flags Details | Diff
patch (3.65 KB, patch)
2022-06-26 22:21 UTC, Yuri Victorovich 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2022-06-26 21:19:27 UTC 
Created attachment 234958 [details]
patch

VTK-6 is long-obsolete and should be deprecated.

Also the project looks for python during build. USES=python is added with related adjustments.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2022-06-26 21:58:59 UTC 
Also math/vtk6 should be deprecated after this since devel/gdcm is the last remaining user.
Comment 2 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2022-06-26 22:04:25 UTC 
Can you resubmit the patch?  I don't have a pre-existing patch-Wrapping_Python_CMakeLists.txt to change.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2022-06-26 22:21:06 UTC 
Created attachment 234959 [details]
patch

Sorry, the patch was wrong due to a bug in my script.

Yuri
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-06-26 23:09:40 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8f5541298099b722e34632ca9ed388bda91064e7

commit 8f5541298099b722e34632ca9ed388bda91064e7
Author:     Stephen Montgomery-Smith <stephen@FreeBSD.org>
AuthorDate: 2022-06-26 23:03:43 +0000
Commit:     Stephen Montgomery-Smith <stephen@FreeBSD.org>
CommitDate: 2022-06-26 23:03:43 +0000

    devel/gdcm: Use latest VTK-9 instead of ancient VTK-6; Add USES=python

    Bump portrevision.

    PR:             264917
    Reported by:    yuri@freebsd.org

 devel/gdcm/Makefile                                | 29 +++++++++++++---------
 ...s_VTK_vtkImageMapToWindowLevelColors2.cxx (new) | 13 ++++++++++
 .../patch-Wrapping_Python_CMakeLists.txt (new)     | 15 +++++++++++
 3 files changed, 45 insertions(+), 12 deletions(-)
Comment 5 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2022-06-26 23:10:12 UTC 
Committed, with portrevision bumped.  Thank you.