Bug 265017 - devel/libepoll-shim: update to 0.0.20220703
Summary: devel/libepoll-shim: update to 0.0.20220703
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL: https://github.com/jiixyj/epoll-shim/...
Keywords: patch
Depends on: 265021 265024
Blocks: 265536
  Show dependency tree / graph
 
Reported: 2022-07-03 18:04 UTC by Jan Beich
Modified: 2022-09-11 12:43 UTC (History)
3 users (show)

See Also:
manu: maintainer-feedback+
eduardo: merge-quarterly?

Attachments
v1 (apply via "git am") (2.01 KB, patch)
2022-07-03 18:04 UTC, Jan Beich 		no flags Details | Diff
libepollshim update (v2) (4.92 KB, patch)
2022-07-05 10:11 UTC, Hans Petter Selasky 		no flags Details | Diff
libepollshim update (v3) (4.26 KB, patch)
2022-07-05 11:54 UTC, Hans Petter Selasky 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2022-07-03 18:04:40 UTC 
Created attachment 235057 [details]
v1 (apply via "git am")
Comment 1 Hans Petter Selasky freebsd_committer freebsd_triage 2022-07-05 08:58:31 UTC 
epoll-shim needs to implement wrappers for open/close/read/write ... whatever like this:

https://github.com/freebsd/freebsd-src/blob/main/contrib/ofed/librdmacm/preload.c

Because other libraries may be doing exactly the same! And then #define is just a wast of debugging time!

I'm working on a patch you can test.

Thanks for bringing this to my attention.
Comment 2 Hans Petter Selasky freebsd_committer freebsd_triage 2022-07-05 10:11:30 UTC 
Created attachment 235079 [details]
libepollshim update (v2)

Hi,

Can you use this patch instead?

Please also help review my changes!

Maybe we need an explicit version check for newer epoll-shim, but I think the current is OK too.

--HPS
Comment 3 Hans Petter Selasky freebsd_committer freebsd_triage 2022-07-05 11:23:26 UTC 
https://github.com/jiixyj/epoll-shim/pull/39
Comment 4 Hans Petter Selasky freebsd_committer freebsd_triage 2022-07-05 11:54:12 UTC 
Created attachment 235080 [details]
libepollshim update (v3)

Removed not needed chunk!
Comment 5 Hans Petter Selasky freebsd_committer freebsd_triage 2022-07-05 11:54:48 UTC 
Ignore that pull request. It is not needed.

--HPS
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-07-05 20:56:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=04db4ece5bdc66c75c8c4ff557e20a06c99e8bf0

commit 04db4ece5bdc66c75c8c4ff557e20a06c99e8bf0
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-06-07 20:00:01 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-07-05 20:54:47 +0000

    devel/libepoll-shim: update to 0.0.20220703

    Changes:        https://github.com/jiixyj/epoll-shim/compare/v0.0.20210418...v0.0.20220703
    Reported by:    portscout
    PR:             265017
    Approved by:    manu
    Co-authored-by: Hans Petter Selasky <hselasky@FreeBSD.org>

 devel/libepoll-shim/Makefile                             |  2 +-
 devel/libepoll-shim/distinfo                             |  6 +++---
 devel/libepoll-shim/pkg-plist                            |  3 +++
 multimedia/libv4l/Makefile                               |  7 ++++---
 multimedia/v4l-utils/Makefile                            |  1 +
 sysutils/rshim-user-space/Makefile                       |  3 ++-
 sysutils/rshim-user-space/files/patch-configure.ac (new) | 16 ++++++++++++++++
 7 files changed, 30 insertions(+), 8 deletions(-)
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2022-09-10 10:21:36 UTC 
Hi,

2022Q3 x11/kitty needs ibepoll-shim-0.0.20220703:

---
LIB_DEPENDS= libepoll-shim-interpose.so:devel/libepoll-shim

CPPFLAGS+=      `pkg-config --cflags epoll-shim-interpose`
LDFLAGS+=       `pkg-config --libs epoll-shim-interpose`
---

Is it possible to MFH: 2022Q3 devel/libepoll-shim 0.0.20220703 ?

Cheers
Comment 8 Jan Beich freebsd_committer freebsd_triage 2022-09-10 18:16:18 UTC 
(In reply to Nuno Teixeira from comment #7)
> Is it possible to MFH: 2022Q3 devel/libepoll-shim 0.0.20220703 ?

When 2022Q4 to be branched in 3 weeks? Go ahead but make sure build-test all consumers (reverse dependencies) on 2022Q3. To speed up testing you may need to use poudriere-devel for "-b quarterly".

Note, I don't maintain this port and this is not a regression fix, so spending more time is not my responsibility.
Comment 9 Nuno Teixeira freebsd_committer freebsd_triage 2022-09-11 12:43:59 UTC 
(In reply to Jan Beich from comment #8)

Hello Jan,

You are right, I will wait for Q4.

Thanks