Bug 265437 - devel/qtcreator: Update to 8.0.1 release, cleanup.
Summary: devel/qtcreator: Update to 8.0.1 release, cleanup.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL: https://www.qt.io/blog/qt-creator-8-r...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-25 17:39 UTC by Florian Walpen
Modified: 2022-08-15 07:10 UTC (History)
2 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments
Update devel/qtcreator to 8.0.0, cleanup. (55.58 KB, patch)
2022-07-25 17:39 UTC, Florian Walpen
no flags Details | Diff
Update devel/qtcreator to 8.0.1, cleanup. (55.63 KB, patch)
2022-08-11 13:01 UTC, Florian Walpen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Walpen 2022-07-25 17:39:28 UTC
Created attachment 235471 [details]
Update devel/qtcreator to 8.0.0, cleanup.

Apart from the update to 8.0.0 release, cleanup the list of shebang files and omit the QmlDesigner resources from being installed. QmlDesigner only builds with Qt 6.2.

Tested on 13.1-RELEASE. I already had the beta and rc1 release candidates in use for some time, and didn't see any regressions.
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2022-07-25 18:08:23 UTC
Moin moin 

Good stuff. 

Little question, can the qmldesigner plugin not be built against Qt5?


mfg Tobias
Comment 2 Florian Walpen 2022-07-25 18:20:45 UTC
(In reply to Tobias C. Berner from comment #1)

> Little question, can the qmldesigner plugin not be built against Qt5?

Moin, I'm away from the build machine, so can't show you the logs right now. But the CMake config message seems pretty clear: Only builds with Qt 6.2+.
I never tried to override it though.

MfG

Florian
Comment 3 Florian Walpen 2022-07-26 11:25:44 UTC
(In reply to Tobias C. Berner from comment #1)

> Little question, can the qmldesigner plugin not be built against Qt5?

Followup, the relevant CMake config message is this:


-- The following features have been disabled:

 * Build online documentation
 * ...
 * Plugin QmlDesigner, with CONDITION Qt5_VERSION VERSION_GREATER_EQUAL 6.2.0 AND TARGET Qt5::QuickWidgets AND TARGET Qt5::Svg
 * Plugin assetexporterplugin, with CONDITION TARGET QmlDesigner
 * Plugin componentsplugin, with CONDITION TARGET QmlDesigner
 * Plugin qmlpreviewplugin, with CONDITION TARGET QmlDesigner
 * Plugin qtquickplugin, with CONDITION TARGET QmlDesigner
 * Plugin StudioPlugin, with CONDITION TARGET QmlDesigner
 * ...


That condition on Qt 6.2.0+ seems pretty clear to me. According to git the QmlDesigner plugin fell out of the pkg-plist with the update to 7.0.0, which was committed by you :-)

MfG

Florian
Comment 4 Florian Walpen 2022-08-11 13:01:00 UTC
Created attachment 235845 [details]
Update devel/qtcreator to 8.0.1, cleanup.

There's been a patch release 8.0.1 of Qt Creator in the meantime, update the ports diff (apply with "git am"). No regressions so far during a short test drive on 13.1-RELEASE.
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-08-14 22:33:12 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=379eb9f1ab6260d4b8e50c552c2bd1a94754c8ee

commit 379eb9f1ab6260d4b8e50c552c2bd1a94754c8ee
Author:     Florian Walpen <dev@submerge.ch>
AuthorDate: 2022-08-14 20:56:10 +0000
Commit:     Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2022-08-14 22:31:45 +0000

    devel/qtcreator: update to 8.0.1 latest upstream

    Update Qt Creator to release 8.0.1, see the release announcements:

            https://www.qt.io/blog/qt-creator-8-released
            https://www.qt.io/blog/qt-creator-8.0.1-released-1

    While here, cleanup the list of shebang files and omit QmlDesigner
    resources from being installed. QmlDesigner only builds with Qt 6.2+.

    PR:             265437
    Obtained from:  Florian Walpen

 devel/qtcreator/Makefile                           |  38 +-
 devel/qtcreator/distinfo                           |   6 +-
 .../files/patch-src_libs_sqlite_CMakeLists.txt     |   6 +-
 devel/qtcreator/pkg-plist                          | 565 ++-------------------
 4 files changed, 63 insertions(+), 552 deletions(-)
Comment 6 Adriaan de Groot freebsd_committer freebsd_triage 2022-08-15 07:10:45 UTC
Landed in the regular ports tree, will hit quarterly next quarter. Thanks Florian!