Bug 265510 - devel/gindent: kill -Werror to fix build
Summary: devel/gindent: kill -Werror to fix build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Neel Chauhan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-30 03:52 UTC by Robert Clausecker
Modified: 2022-08-09 20:51 UTC (History)
2 users (show)

See Also:
moritz: maintainer-feedback+
fuz: merge-quarterly?

Attachments
devel/gindent: fix build (1.15 KB, patch)
2022-07-30 03:52 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-07-30 03:52:00 UTC 
Created attachment 235551 [details]
devel/gindent: fix build

The code currently does not build due to an unused variable.
Remove -Werror to make it build.  Please note that as per policy,
options like -Werror should generally not be used in ports.

Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
Comment 1 Moritz Schmitt 2022-08-09 09:55:00 UTC 
Looks good, thanks!
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2022-08-09 15:41:04 UTC 
Comment on attachment 235551 [details]
devel/gindent: fix build

Maintainer approval was granted.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-08-09 20:50:25 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5d38de488ba0413c33ba55cf368c6dc4575c8cf3

commit 5d38de488ba0413c33ba55cf368c6dc4575c8cf3
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-07-30 03:44:27 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2022-08-09 20:48:50 +0000

    devel/gindent: fix build

    Remove -Werror as per policy.

    PR:             265510
    Approved by:    Robert Clausecker <moritz AT schmi DOT tt> (maintainer)
    MFH:            2022Q3 (build fix blanket)

 devel/gindent/files/patch-src_Makefile.in (new) | 11 +++++++++++
 1 file changed, 11 insertions(+)
Comment 4 Neel Chauhan freebsd_committer freebsd_triage 2022-08-09 20:51:11 UTC 
Committed & MFH'd!
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-08-09 20:51:26 UTC 
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5fc1113283a5b303374a932b84ee7bce23c077c4

commit 5fc1113283a5b303374a932b84ee7bce23c077c4
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-07-30 03:44:27 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2022-08-09 20:50:35 +0000

    devel/gindent: fix build

    Remove -Werror as per policy.

    PR:             265510
    Approved by:    Robert Clausecker <moritz AT schmi DOT tt> (maintainer)
    MFH:            2022Q3 (build fix blanket)

    (cherry picked from commit 5d38de488ba0413c33ba55cf368c6dc4575c8cf3)

 devel/gindent/files/patch-src_Makefile.in (new) | 11 +++++++++++
 1 file changed, 11 insertions(+)