Bug 265603 - [LIBM] Correct comments in s_cbrt[l].c
Summary: [LIBM] Correct comments in s_cbrt[l].c
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-numerics (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-03 16:49 UTC by Steve Kargl
Modified: 2022-08-10 02:10 UTC (History)
3 users (show)

See Also:
dim: mfc-stable13+
dim: mfc-stable12+


Attachments
Patch to fix PR (888 bytes, patch)
2022-08-03 16:49 UTC, Steve Kargl
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Kargl freebsd_committer freebsd_triage 2022-08-03 16:49:29 UTC
Created attachment 235657 [details]
Patch to fix PR

In a serious of email exchanges with Damian McGuckin <damianm at esi dot com dot au> about proving the accuracy claims in cbrt() and cbrtl(), Damian found an error in the comments in the code.  The attached patch rectifies the situation.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-08-04 17:35:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=369ea0520a3061c07400d7cd32172efb6af39815

commit 369ea0520a3061c07400d7cd32172efb6af39815
Author:     Steve Kargl <kargl@FreeBSD.org>
AuthorDate: 2022-08-04 17:31:57 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2022-08-04 17:33:34 +0000

    [libm] Correct comments in s_cbrt[l].c

    Damian McGuckin <damianm at esi dot com dot au> noted that the accuracy
    claims in the code for cbrt(3) and cbrtl(3) were incorrect. Fix the
    comments to more accurately describe the accuracies.

    PR:             265603
    MFC after:      3 days

 lib/msun/src/s_cbrt.c  | 2 +-
 lib/msun/src/s_cbrtl.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-08-07 09:06:26 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=9a0d922f57f2aacee8aee7a190f4dcc1cd5d8bf9

commit 9a0d922f57f2aacee8aee7a190f4dcc1cd5d8bf9
Author:     Steve Kargl <kargl@FreeBSD.org>
AuthorDate: 2022-08-04 17:31:57 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2022-08-07 09:02:36 +0000

    [libm] Correct comments in s_cbrt[l].c

    Damian McGuckin <damianm at esi dot com dot au> noted that the accuracy
    claims in the code for cbrt(3) and cbrtl(3) were incorrect. Fix the
    comments to more accurately describe the accuracies.

    PR:             265603
    MFC after:      3 days

    (cherry picked from commit 369ea0520a3061c07400d7cd32172efb6af39815)

 lib/msun/src/s_cbrt.c  | 2 +-
 lib/msun/src/s_cbrtl.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-08-07 09:06:27 UTC
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=162bdeaa7324c4c75b015530eac4bcbd6c58d639

commit 162bdeaa7324c4c75b015530eac4bcbd6c58d639
Author:     Steve Kargl <kargl@FreeBSD.org>
AuthorDate: 2022-08-04 17:31:57 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2022-08-07 09:03:20 +0000

    [libm] Correct comments in s_cbrt[l].c

    Damian McGuckin <damianm at esi dot com dot au> noted that the accuracy
    claims in the code for cbrt(3) and cbrtl(3) were incorrect. Fix the
    comments to more accurately describe the accuracies.

    PR:             265603
    MFC after:      3 days

    (cherry picked from commit 369ea0520a3061c07400d7cd32172efb6af39815)

 lib/msun/src/s_cbrt.c  | 2 +-
 lib/msun/src/s_cbrtl.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 4 gemmalyly 2022-08-10 02:10:17 UTC
MARKED AS SPAM