Created attachment 235781 [details] 0.21.0 Attached patch updates bat to v0.21.0. As far as I can tell, the libgit2 dependency is unused; bat builds and exclusively uses an internally-built libgit2. I've removed that dependency in this patch.
Thanks for opening the PR. I'm investigating the libgit stuff. The libgit2-sys crate is configured by Uses/cargo.mk to use the installed libgit2 library, not the bundle one. The wanted behavior is to use the shared library, not to compile an internal one.
I've found the reason: libgit2 in ports is on the 1.3.x stable release path. libgit2-sys needs libgit2 1.4 or 1.5 I'm reaching out to libgit2 maintainer to decide what to do next. However, I would keep the libgit2 dependency as it is, waiting for a fix.
Comment on attachment 235781 [details] 0.21.0 libgit2 is not used, but it should, so I would keep the dependency to make it explicit
(In reply to Luca Pizzamiglio from comment #3) OK, other than adding in libgit2 and bumping PORTREVISION when libgit2 is updated, is the patch ready for commit?
yes, the patch is good to land
Well, in my brilliance I forgot to include the PR in the commit. But, this is committed. https://cgit.freebsd.org/ports/commit/?id=b6c5a286dc27f3cd2ddbe7d7653936bb7c847925 I'm closing out this PR. Thanks for the review, Luca!