Created attachment 235867 [details] small modification in "usr.sbin/bsdinstall/scripts/fetchmissingdists" The 'error' function in the script "usr.sbin/bsdinstall/scripts/fetchmissingdists" has this statement: bsddialog --backtitle "FreeBSD Installer" --title "Error" --msgbox "$1" 0 0 The suggested change is proposing this statement : bsddialog --backtitle "$OSNAME Installer" --title "Error" --msgbox "$1" 0 0 the $OSNAME variable declared in the Makefile contained in the bsdinstall directory centrally controls the name of the Operating System so this is consistent with other scripts in the bsdinstall directory.
Review: https://reviews.freebsd.org/D36235 The Makefile controls OSNAME in the tools written in C, partedit, distextract and distfetch. The OSNAME in the scripts is controlled by bsdconfig "/usr/share/bsdconfig/common.subr".
(In reply to Alfonso S. Siciliano from comment #1) Thank you for the thread. The review ( https://reviews.freebsd.org/D36235 ) does contain the same modifications I proposed. In addition, thanks for the pointer. I'm still hard at work to get a better understanding of how this beastie works. slowly but surely!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=2913e785f057f54f7ee825fe4f9fe3c039c0f78f commit 2913e785f057f54f7ee825fe4f9fe3c039c0f78f Author: Brad Davis <brd@FreeBSD.org> AuthorDate: 2022-09-14 17:04:07 +0000 Commit: Brad Davis <brd@FreeBSD.org> CommitDate: 2022-09-14 17:06:11 +0000 bsdinstall: fix a couple stragglers in whitelabeling the scripts PR: 265797 Reviewed by: allanjude, asiciliano Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D36235 usr.sbin/bsdinstall/scripts/checksum | 2 +- usr.sbin/bsdinstall/scripts/fetchmissingdists | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-)
Good catch, sorry I didn't see this until after I opened the review.