Bug 266071 - graphics/sdl2_image: update to 2.6.2
Summary: graphics/sdl2_image: update to 2.6.2
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL: https://discourse.libsdl.org/t/announ...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2022-08-27 15:32 UTC by Jan Beich
Modified: 2022-08-31 11:24 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (amdmi3)


Attachments
v1 (apply via "git am") (3.58 KB, patch)
2022-08-27 15:32 UTC, Jan Beich
no flags Details | Diff
v1 (apply via "git am") (3.58 KB, patch)
2022-08-27 15:37 UTC, Jan Beich
no flags Details | Diff
v1.1 (apply via "git am") (3.71 KB, patch)
2022-08-27 16:29 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2022-08-27 15:32:07 UTC
Created attachment 236151 [details]
v1 (apply via "git am")

- "make test" requires re-running "make configure" with --enable-tests
- Enabling AVIF and JXL maybe required by https://github.com/renpy/pygame_sdl2/pull/142
- Keeping JPEG and PNG requires --disable-stb-image to avoid bundled library; see also
  https://github.com/archlinux/svntogit-packages/commit/12d9b1ca2ac9
  https://github.com/libsdl-org/SDL_image/commit/797ada838308
  https://github.com/libsdl-org/SDL_image/issues/133
Comment 1 Jan Beich freebsd_committer freebsd_triage 2022-08-27 15:37:39 UTC
Created attachment 236152 [details]
v1 (apply via "git am")

Typo: AUTOCONF_ARGS -> CONFIGURE_ARGS
Comment 2 Jan Beich freebsd_committer freebsd_triage 2022-08-27 16:29:35 UTC
Created attachment 236153 [details]
v1.1 (apply via "git am")

Drop devel/libunwind dependency in favor checking at build. Optional in both devel/sdl20 and graphics/mesa-libs but complicated by different ABI (with same API) between implementations. For example, on riscv64 graphics/mesa-libs doesn't use devel/libunwind.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2022-08-31 11:23:53 UTC
I've had cmake based update WIP for a long time, so unfortunately the patch is of no use. Enabling AVIF and JXL by default though.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-08-31 11:24:58 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=620b7c2a34b764b5cc79ca184b521b2660bfac21

commit 620b7c2a34b764b5cc79ca184b521b2660bfac21
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2022-08-31 11:18:58 +0000
Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
CommitDate: 2022-08-31 11:23:41 +0000

    graphics/sdl2_image: enable AVIF and JXL by default

    These may be needed for games/renpy

    Requested by:   jbeich
    PR:             266071

 graphics/sdl2_image/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)