Created attachment 236807 [details] Patch for png - Switch to CMake - Switch apng repo to https://sourceforge.net/projects/libpng-apng/ (same as Gentoo uses) Compile and runtime tested on FreeBSD 13.1-STABLE (amd64) (make, make check-plist, make test) Compile and runtime tested on FreeBSD FreeBSD 13.1-RELEASE-p1 (arm64) (make, make check-plist, make test) Poudriere testport OK 12.3-RELEASE (amd64) Poudriere testport OK 13.1-RELEASE (i386) Changelog: https://github.com/glennrp/libpng/blob/v1.6.38/CHANGES Reference: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=437a2672807d5af06d7c6185db20e3f318570f65
I'd suggest that we do an exp-run to avoid unnecessary breakage.
(In reply to Daniel Engberg from comment #1) yes, exp-run is required
Is there anything else I need to do before we can request exp-run?
(In reply to Daniel Engberg from comment #3) no, just request it ^^ sorry if I was not clear about that.
Hi, I'd like to request an exp-run on behalf of desktop@ Best regards, Daniel
You removed: -USE_CSTD= gnu89 Did you verify that it builds with llvm15? You added TEST as an option, this doesn't make sense (the content of the package doesn't change), please remove TEST option and use CMAKE_ON=PNG_TESTS so that everybody can run regression tests after build Did you verify that it builds on armv7?
Created attachment 237023 [details] Patch for png v2 Use USES= cmake:testing instead of menu option to toggle building of unit tests
Builds with llvm15 (amd64) Unfortunately I don't have any way of testing armv7
Some new failure logs: http://pb2.nyi.freebsd.org/data/123i386-default-foo/2022-10-07_07h08m40s/logs/errors/dosbox-staging-0.78.1.log http://pb2.nyi.freebsd.org/data/123i386-default-foo/2022-10-07_07h08m40s/logs/errors/azpainter-2.1.7.log http://pb2.nyi.freebsd.org/data/123i386-default-foo/2022-10-07_07h08m40s/logs/errors/azpainterb-1.1.3.log
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ffdc2e6bbe93c03233e5f5afeb377f0e89e748cd commit ffdc2e6bbe93c03233e5f5afeb377f0e89e748cd Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2022-10-10 22:40:21 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2022-10-10 22:43:55 +0000 graphics/azpainter: Prepare for png 1.6.38 Adjust LIBS to include -lz PR: 266599 Approved by: portmgr (blanket) graphics/azpainter/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=612bfd09df8bb66716f770d773550145db88a9e5 commit 612bfd09df8bb66716f770d773550145db88a9e5 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2022-10-10 22:42:56 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2022-10-10 22:43:56 +0000 graphics/azpainterb: Prepare for png 1.6.38 Adjust LIBS to include -lz PR: 266599 Approved by: portmgr (blanket) graphics/azpainterb/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=729e40da692665dc93e84f6010bd3a34bc6cf807 commit 729e40da692665dc93e84f6010bd3a34bc6cf807 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2022-10-10 22:29:51 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2022-10-10 22:43:55 +0000 emulators/dosbox-staging: Prepare for png 1.6.38 Adjust LDFLAGS to include -lz PR: 266599 Approved by: portmgr (blanket) emulators/dosbox-staging/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Friendly ping
Exp-run looks fine
The patch looks good.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9f4f89ec947067351dee8e6887d268e92ec0f317 commit 9f4f89ec947067351dee8e6887d268e92ec0f317 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2022-10-16 19:42:23 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2022-10-16 21:21:17 +0000 graphics/png: Update to 1.6.38 - Switch to CMake - Switch apng repo to https://sourceforge.net/projects/libpng-apng Changelog: https://github.com/glennrp/libpng/blob/v1.6.38/CHANGES PR: 266599 Approved by: desktop (arrowd) Exp-run by: antoine graphics/png/Makefile | 27 ++++++++++++--------------- graphics/png/distinfo | 10 +++++----- graphics/png/files/patch-configure (gone) | 11 ----------- graphics/png/pkg-plist | 10 ++++++---- 4 files changed, 23 insertions(+), 35 deletions(-)