Bug 266631 - editors/libreoffice: drop LLVM13 and binutils for LTO
Summary: editors/libreoffice: drop LLVM13 and binutils for LTO
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: FreeBSD Office Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-26 16:58 UTC by Piotr Kubaj
Modified: 2022-09-27 12:30 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (office)

Attachments
patch (785 bytes, text/plain)
2022-09-26 16:58 UTC, Piotr Kubaj 		no flags Details
v2 (569 bytes, patch)
2022-09-27 01:05 UTC, Piotr Kubaj 		fluffy: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2022-09-26 16:58:32 UTC 
Created attachment 236838 [details]
patch

Builds fine with LTO without those dependencies now.
Comment 1 Dima Panov freebsd_committer freebsd_triage 2022-09-26 19:50:42 UTC 
Moin!

At least 12.3 still need this due to llvm10 in the base
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2022-09-27 01:05:43 UTC 
Created attachment 236850 [details]
v2

Would that be OK?
Comment 3 Piotr Kubaj freebsd_committer freebsd_triage 2022-09-27 01:06:57 UTC 
Also, it's possible that LLVM 10 can build it. Libreoffice changed a bit since I added that LTO block, it previously insisted on using LLVM Gold plugin and ld.bfd, but now doesn't.
Comment 4 Dima Panov freebsd_committer freebsd_triage 2022-09-27 06:40:58 UTC 
Comment on attachment 236850 [details]
v2

LGTM
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-09-27 12:30:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=44ed27f46b05c031306bb124ea091423d1ed8dfa

commit 44ed27f46b05c031306bb124ea091423d1ed8dfa
Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
AuthorDate: 2022-09-27 12:29:05 +0000
Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
CommitDate: 2022-09-27 12:29:52 +0000

    editors/libreoffice: drop LLVM13 and binutils for LTO on 13.1 and newer

    PR:     266631
    Approved by:    fluffy@

 editors/libreoffice/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)