Bug 266668 - audio/audacity: Update to 3.2.0
Summary: audio/audacity: Update to 3.2.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL: https://www.audacityteam.org/
Keywords: needs-qa
Depends on:
Blocks: 262448
  Show dependency treegraph
 
Reported: 2022-09-28 04:14 UTC by Jack
Modified: 2022-10-05 15:39 UTC (History)
2 users (show)

See Also:
xxjack12xx: maintainer-feedback+


Attachments
Patch to upgrade audacity to 3.2.0 from 3.1.3 (7.99 KB, patch)
2022-09-28 04:14 UTC, Jack
xxjack12xx: maintainer-approval+
Details | Diff
Upgrade audacity to 3.2.0 (8.06 KB, patch)
2022-09-30 07:21 UTC, Jack
xxjack12xx: maintainer-approval+
Details | Diff
Upgrade to audacity 3.2.0 (8.30 KB, patch)
2022-09-30 23:45 UTC, Jack
xxjack12xx: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2022-09-28 04:14:53 UTC
Created attachment 236892 [details]
Patch to upgrade audacity to 3.2.0 from 3.1.3

Patch to upgrade audacity from 3.1.3 to 3.2.0

This should also resolve https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262448

vst3 support is broken and is disabled for now.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-30 05:53:58 UTC
It doesn't work for me. It fails to configure:

wxWidgets_LIBRARIES=general;-L/usr/local/lib;general;-pthread;general;-lwx_baseu-3.1;general;-lwx_gtk3u_core-3.1;general;-lwx_gtk3u_html-3.1;general;-lwx_gtk3u_qa-3.1;general;-lwx_baseu_xml-3.1;general;-lwx_baseu_net-3.1
wxWidgets_LIBRARY_DIRS=/usr/local/lib
-- Using 'wxWidgets' system library
-- Checking for module 'lame >= 3.100'
--   Package 'lame', required by 'virtual:world', not found
-- Using 'libmp3lame' system library
-- Checking for module 'libmpg123'
--   Package 'libmpg123', required by 'virtual:world', not found
CMake Error at cmake-proxies/cmake-modules/AudacityDependencies.cmake:238 (message):
  Failed to find the system package mpg123
Call Stack (most recent call first):
  cmake-proxies/CMakeLists.txt:112 (add_conan_lib)


-- Configuring incomplete, errors occurred!
See also "/wrkdirs/usr/ports/audio/audacity/work/.build/CMakeFiles/CMakeOutput.log".
See also "/wrkdirs/usr/ports/audio/audacity/work/.build/CMakeFiles/CMakeError.log".
*** Error code 1

Would you have a look at it?

Thanks!
Comment 2 Jack 2022-09-30 06:39:51 UTC
Will check, sounds like a dependency check is missing.
Comment 3 Jack 2022-09-30 07:21:01 UTC
Created attachment 236959 [details]
Upgrade audacity to 3.2.0

Includes check on mpg dependency.
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-30 10:04:08 UTC
It seems more deps are missing :-(

-- Checking for module 'wavpack >= 5.2.0'
--   Package 'wavpack', required by 'virtual:world', not found
CMake Error at cmake-proxies/cmake-modules/AudacityDependencies.cmake:238 (message):
  Failed to find the system package WavPack
Call Stack (most recent call first):
  cmake-proxies/CMakeLists.txt:146 (add_conan_lib)
Comment 5 Jack 2022-09-30 10:13:10 UTC
let me get a clean machine and try to catch them all
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-30 10:15:46 UTC
(In reply to Jack from comment #5)
Wouldn't poudriere help here?
Comment 7 Jack 2022-09-30 10:17:14 UTC
(In reply to Fernando Apesteguía from comment #6)
i'm behind on the times, i need to set that up one day
Comment 8 Jack 2022-09-30 23:45:31 UTC
Created attachment 236977 [details]
Upgrade to audacity 3.2.0

It looks like wavpack was the only missing dep, added that to patch.
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-01 13:52:45 UTC
(In reply to Jack from comment #8)


:-(

Please, please, please. Check the ports in a clean environment. I can't emphasize enough how easy and convenient poudriere is.

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%DOCSDIR%%/README.txt
===> Error: Plist issues found.
*** Error code 1
Comment 10 Jack 2022-10-02 00:16:10 UTC
Arg, I'll try and set that up
Comment 11 Jack 2022-10-04 06:10:38 UTC
I tried to set up poudriere but some dependency (llvm13) keeps using up all the ram and crashing the system. I've just installed a new clean install of FreeBSD 13.1 and building audacity 3.2.0 now. Hopefully can catch all the issues with the clean install.
Comment 12 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-04 06:45:20 UTC
(In reply to Jack from comment #11)
Thanks a lot. I would use  packages if at all possible. llvm, rust, etc are very memory hungry.

About the port, I tried to run it and it fails complaining about not finding libflac IIRC.
Comment 13 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-05 15:14:37 UTC
(In reply to Fernando Apesteguía from comment #12)
Argg. My fault. I was testing in a jail that pointed to quarterly and the libFLAC.so there was not .12 as in latest where it was built.

My apologies. I'll push this soon.
Comment 14 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-05 15:38:11 UTC
Committed,

Thanks!
Comment 15 commit-hook freebsd_committer freebsd_triage 2022-10-05 15:38:40 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6d9b7dea668df2009e3fd41675991fa253bbbf34

commit 6d9b7dea668df2009e3fd41675991fa253bbbf34
Author:     Jack <xxjack12xx@gmail.com>
AuthorDate: 2022-10-01 12:02:47 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-10-05 15:34:11 +0000

    audio/audacity: Update to 3.2.0

    ChangeLog: https://www.audacityteam.org/

    PR:             266668
    Reported by:    xxjack12xx@gmail.com (maintainer)

 audio/audacity/Makefile                                | 10 ++++++----
 audio/audacity/distinfo                                |  6 +++---
 .../audacity/files/patch-cmake-proxies_CMakeLists.txt  | 18 +++++++++---------
 .../patch-lib-src_libnyquist_nyquist_xlisp_xlisp.h     |  4 ++--
 .../patch-libraries_lib-basic-ui_BasicUI.cpp (new)     | 10 ++++++++++
 audio/audacity/files/patch-src_AboutDialog.cpp         |  4 ++--
 audio/audacity/files/patch-src_CMakeLists.txt (gone)   | 11 -----------
 audio/audacity/files/patch-src_MIDIPlay.cpp            | 12 ++++++------
 audio/audacity/pkg-plist                               | 14 +++++++++++---
 9 files changed, 49 insertions(+), 40 deletions(-)