Created attachment 236929 [details]
Fixed rc script

The patch in commit eb65cf5cbe543a6372834bee33243344bc40f737 to "silence checkvm_cmd" is incorrect.

This line:

checkvm_cmd="%%PREFIX%%/bin/vmware-checkvm > /dev/null 2>&1"

does not cause stdout and stderr redirection, it simply passes the three extra tokens to the vmware-checkvm command in argv.

The correct solution is to define checkvm_cmd as a function:

checkvm_cmd()
{
  %%PREFIX%%/bin/vmware-checkvm > /dev/null 2>&1
}

This error causes our puppet manifests to break because the extraneous output from `service vmware-guestd rcvar` causes puppet's FreeBSD "service" resource provider to barf.

I've attached a fixed version of vmware-guestd.in.   In theory vmware-kmod.in has the same issue but it hasn't bitten us the way this one did.