Bug 266702 - sysutils/fakertc: update to v3
Summary: sysutils/fakertc: update to v3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL: https://github.com/ronaldklop/fakertc...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-29 11:38 UTC by Ronald Klop
Modified: 2022-09-29 18:55 UTC (History)
1 user (show)

See Also:


Attachments
git diff of sysutils/fakertc (1.25 KB, patch)
2022-09-29 11:38 UTC, Ronald Klop
ronald-lists: maintainer-approval+
Details | Diff
git diff of sysutils/fakertc (1.31 KB, patch)
2022-09-29 18:31 UTC, Ronald Klop
ronald-lists: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ronald Klop 2022-09-29 11:38:55 UTC
Created attachment 236942 [details]
git diff of sysutils/fakertc

Version 3.

Added a weekly cron to keep the fakertc file a bit more up-to-date which helps on an unclean reboot.
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2022-09-29 15:26:57 UTC
Hello,

Should it be:

+ ${MKDIR} ${STAGEDIR}${PREFIX}/etc/cron.d
- ${MKDIR} ${WRKSRC}/src/etc/cron.d

Cheers
Comment 2 Ronald Klop 2022-09-29 17:13:17 UTC
(In reply to Nuno Teixeira from comment #1)
Yes. Ouch. Last minute test reverted wrongly.
Thanks for the review!
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2022-09-29 17:19:52 UTC
(In reply to Ronald Klop from comment #2)
Should I wait for a new diff?
Comment 4 Ronald Klop 2022-09-29 18:31:50 UTC
Created attachment 236952 [details]
git diff of sysutils/fakertc

Fix mkdir in new patch. Added slashes to the install commands to make sure they error on non-existent dirs.
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-09-29 18:55:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=52dea9071b68d0a89193e15b985da717b9e561f3

commit 52dea9071b68d0a89193e15b985da717b9e561f3
Author:     Ronald Klop <ronald-lists@klop.ws>
AuthorDate: 2022-09-29 18:51:49 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-09-29 18:54:50 +0000

    sysutils/fakertc: Update to v3

     - Added slashes to the install commands to make sure they error on
       non-existent dirs

    ChangeLog:      https://github.com/ronaldklop/fakertc/releases/tag/v3
    PR:             266702

 sysutils/fakertc/Makefile | 9 ++++++---
 sysutils/fakertc/distinfo | 6 +++---
 2 files changed, 9 insertions(+), 6 deletions(-)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2022-09-29 18:55:59 UTC
Committed, thanks!