Bug 266716 - devel/p5-Term-Size: Update to 0.211
Summary: devel/p5-Term-Size: Update to 0.211
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Wen Heping
URL: https://metacpan.org/dist/Term-Size/c...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-30 08:10 UTC by Gian-Simon Purkert
Modified: 2022-10-08 00:26 UTC (History)
2 users (show)

See Also:
brad: maintainer-feedback+


Attachments
Update to 0.211 (833 bytes, patch)
2022-09-30 08:10 UTC, Gian-Simon Purkert
gspurki: maintainer-approval+
Details | Diff
Update to 0.211 (833 bytes, patch)
2022-10-02 13:47 UTC, Gian-Simon Purkert
gspurki: maintainer-approval+
Details | Diff
Update to 0.211 (1.15 KB, patch)
2022-10-07 12:53 UTC, Gian-Simon Purkert
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gian-Simon Purkert 2022-09-30 08:10:20 UTC
Created attachment 236960 [details]
Update to 0.211
Comment 1 brad 2022-09-30 14:52:16 UTC
(In reply to Gian-Simon Purkert from comment #0)
Looks good to me.
Comment 2 Gian-Simon Purkert 2022-10-01 06:59:08 UTC
(In reply to brad from comment #1)

Hi Brad,

I set maintainer-approval to + since you said it's ok.

Best regards,
Gian-Simon
Comment 3 Gian-Simon Purkert 2022-10-02 13:47:32 UTC
Created attachment 237017 [details]
Update to 0.211

Change to Distversion
Comment 4 brad 2022-10-02 20:10:53 UTC
Comment on attachment 237017 [details]
Update to 0.211

LGTM
Comment 5 brad 2022-10-02 20:14:19 UTC
Comment on attachment 237017 [details]
Update to 0.211

I don't appear to be able to set maintainer-approval but would do so if I could.
Comment 6 Gian-Simon Purkert 2022-10-02 20:42:32 UTC
(In reply to brad from comment #5)

Hy,

On the left side of the attachment you have "Details" click on it and set " 	maintainer-approval" to "+" then click "Submit"

Thank you very much an have a great Day,

Gian-Simon
Comment 7 Gian-Simon Purkert 2022-10-02 20:43:29 UTC
right...right side ;(
Comment 8 brad 2022-10-02 21:17:48 UTC
(In reply to Gian-Simon Purkert from comment #7)
Doing so doesn't seem to take - it looks like it should be defaulting to ? for me to do so, but it's defaulting to X, which (as I understand it) means it doesn't think I should be setting that flag.
Comment 9 Gian-Simon Purkert 2022-10-03 07:17:24 UTC
Comment on attachment 237017 [details]
Update to 0.211

->Comment 5
Comment 10 Wen Heping freebsd_committer freebsd_triage 2022-10-07 12:42:34 UTC
The build failed, the revised patch :

--- a/devel/p5-Term-Size/Makefile
+++ b/devel/p5-Term-Size/Makefile
@@ -1,6 +1,5 @@
 PORTNAME=      Term-Size
-PORTVERSION=   0.207
-PORTREVISION=  1
+PORTVERSION=   0.211
 CATEGORIES=    devel perl5
 MASTER_SITES=  CPAN
 PKGNAMEPREFIX= p5-
diff --git a/devel/p5-Term-Size/distinfo b/devel/p5-Term-Size/distinfo
index 7f682bda16f3..0bccce1ea3bc 100644
--- a/devel/p5-Term-Size/distinfo
+++ b/devel/p5-Term-Size/distinfo
@@ -1,2 +1,3 @@
-SHA256 (Term-Size-0.207.tar.gz) = b04a14b5663b83a49e2516538b5e133409eb38f84ae157b6b200eda595fca21c
-SIZE (Term-Size-0.207.tar.gz) = 4744
+TIMESTAMP = 1665145959
+SHA256 (Term-Size-0.211.tar.gz) = 5962b4bde52329774718296c92315e936da7f9c4451e92186cf072f27790b3fb
+SIZE (Term-Size-0.211.tar.gz) = 5416
diff --git a/devel/p5-Term-Size/pkg-plist b/devel/p5-Term-Size/pkg-plist
index efaa6abdeae0..9fac24c593f0 100644
--- a/devel/p5-Term-Size/pkg-plist
+++ b/devel/p5-Term-Size/pkg-plist
@@ -1,4 +1,3 @@
 %%SITE_ARCH%%/Term/Size.pm
 %%SITE_ARCH%%/auto/Term/Size/Size.so
-%%SITE_ARCH%%/auto/Term/Size/autosplit.ix
 %%PERL5_MAN3%%/Term::Size.3.gz
Comment 11 Gian-Simon Purkert 2022-10-07 12:53:54 UTC
Created attachment 237139 [details]
Update to 0.211
Comment 12 Gian-Simon Purkert 2022-10-07 12:58:34 UTC
(In reply to Wen Heping from comment #10)

Hy,

Why is the patch Portversion? I thought "Distversion" is the correct way if the packet from the source is version is 0.211?

https://docs.freebsd.org/en/books/porters-handbook/makefiles/

>>5.2.2. Versions, DISTVERSION or PORTVERSION

>>Set DISTVERSION to the version number of the software.

>>PORTVERSION is the version used for the FreeBSD package. It will be >>automatically derived from DISTVERSION to be compatible with FreeBSD’s package >>versioning scheme.
Comment 13 Wen Heping freebsd_committer freebsd_triage 2022-10-07 13:58:26 UTC
(In reply to Gian-Simon Purkert from comment #12)
--- a/devel/p5-Term-Size/Makefile
+++ b/devel/p5-Term-Size/Makefile
@@ -1,6 +1,5 @@
 PORTNAME=      Term-Size
-PORTVERSION=   0.207
-PORTREVISION=  1
+DISTVERSION=   0.211
 CATEGORIES=    devel perl5
 MASTER_SITES=  CPAN
 PKGNAMEPREFIX= p5-
diff --git a/devel/p5-Term-Size/distinfo b/devel/p5-Term-Size/distinfo
index 7f682bda16f3..0bccce1ea3bc 100644
--- a/devel/p5-Term-Size/distinfo
+++ b/devel/p5-Term-Size/distinfo
@@ -1,2 +1,3 @@
-SHA256 (Term-Size-0.207.tar.gz) = b04a14b5663b83a49e2516538b5e133409eb38f84ae157b6b200eda595fca21c
-SIZE (Term-Size-0.207.tar.gz) = 4744
+TIMESTAMP = 1665145959
+SHA256 (Term-Size-0.211.tar.gz) = 5962b4bde52329774718296c92315e936da7f9c4451e92186cf072f27790b3fb
+SIZE (Term-Size-0.211.tar.gz) = 5416
diff --git a/devel/p5-Term-Size/pkg-plist b/devel/p5-Term-Size/pkg-plist
index efaa6abdeae0..9fac24c593f0 100644
--- a/devel/p5-Term-Size/pkg-plist
+++ b/devel/p5-Term-Size/pkg-plist
@@ -1,4 +1,3 @@
 %%SITE_ARCH%%/Term/Size.pm
 %%SITE_ARCH%%/auto/Term/Size/Size.so
-%%SITE_ARCH%%/auto/Term/Size/autosplit.ix
 %%PERL5_MAN3%%/Term::Size.3.gz
Comment 14 Gian-Simon Purkert 2022-10-07 15:23:16 UTC
(In reply to Wen Heping from comment #13)

It's the same as my attachment from comment 11 (or top)
Comment 15 commit-hook freebsd_committer freebsd_triage 2022-10-08 00:25:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=06ade0876922bbbd44c0c1b791652903cff865fd

commit 06ade0876922bbbd44c0c1b791652903cff865fd
Author:     Wen Heping <wen@FreeBSD.org>
AuthorDate: 2022-10-08 00:23:53 +0000
Commit:     Wen Heping <wen@FreeBSD.org>
CommitDate: 2022-10-08 00:23:53 +0000

    devel/p5-Term-Size: Update to 0.211

    PR:             266716
    Reported by:    gspurki@gmail.com
    Approved by:    maintainer

 devel/p5-Term-Size/Makefile  | 3 +--
 devel/p5-Term-Size/distinfo  | 5 +++--
 devel/p5-Term-Size/pkg-plist | 1 -
 3 files changed, 4 insertions(+), 5 deletions(-)