Bug 266769 - www/caddy: service doesn't stop/restart properly
Summary: www/caddy: service doesn't stop/restart properly
Status: Closed DUPLICATE of bug 255106
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-02 18:41 UTC by Mark Felder
Modified: 2022-10-02 19:22 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (adamw)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Felder freebsd_committer freebsd_triage 2022-10-02 18:41:12 UTC 
Caddy can't stop/restart properly when you disable the admin interface in the config because those subcommands actually make HTTP requests to the admin API endpoint:

{
    admin off
}


The rc script should only use the caddy command for the config reload and do the normal stop/restart through SIGTERM
Comment 1 Adam Weinberger freebsd_committer freebsd_triage 2022-10-02 18:49:16 UTC 
Are you using head or quarterly? Head had changes in the past week or two that were designed to do exactly that.

The goal is that when the admin API fails, it sends the usual signals based on the pidfile. If the version in head isn't doing that, then I need to go back to the drawing board.
Comment 2 Mark Felder freebsd_committer freebsd_triage 2022-10-02 19:22:19 UTC 

*** This bug has been marked as a duplicate of bug 255106 ***