Bug 266803 - ftp/lftp build fails with libressl 3.5.3
Summary: ftp/lftp build fails with libressl 3.5.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ganael LAPLANCHE
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-03 20:40 UTC by tjlegg
Modified: 2022-10-05 18:47 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (martymac)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tjlegg 2022-10-03 20:40:00 UTC 
This fix is pretty simple. files/patch-src_lftp__ssl.cc currently has #if OPENSSL_VERSION_NUMBER < 0x10100000L || LIBRESSL_VERSION_NUMBER as a past fix for libressl. Now the fix is #if OPENSSL_VERSION_NUMBER < 0x10100000L || LIBRESSL_VERSION_NUMBER < 0x03050000f

Builds successfully on 13.1 stable
Comment 1 Ganael LAPLANCHE freebsd_committer freebsd_triage 2022-10-05 18:37:12 UTC 
Hello,

Thanks a lot for your report.

That bug has already been fixed upstream:

https://github.com/lavv17/lftp/commit/3ffa0132987bdde986c82c924bc51b13b37f8b54

so I'll just backport the patch.

Cheers,

Ganael.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-10-05 18:46:07 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9a36ff5299c8de0f7a97093fcfe88a2befc0fe35

commit 9a36ff5299c8de0f7a97093fcfe88a2befc0fe35
Author:     Ganael LAPLANCHE <martymac@FreeBSD.org>
AuthorDate: 2022-10-05 18:38:05 +0000
Commit:     Ganael LAPLANCHE <martymac@FreeBSD.org>
CommitDate: 2022-10-05 18:45:45 +0000

    ftp/lftp: Fix build with libressl >= 2.7.0

    While here, re-generate patches using makepatch target.

    PR:             266803
    Reported by:    tjlegg@gmail.com
    Obtained from:  https://github.com/lavv17/lftp/commit/3ffa0132987bdde986c82c924bc51b13b37f8b54

 ftp/lftp/files/patch-src-Makefile.in  | 4 ++--
 ftp/lftp/files/patch-src_lftp__ssl.cc | 9 +++++++++
 2 files changed, 11 insertions(+), 2 deletions(-)