Bug 266838 - net/mpd5: 5.9_10 upstream r2454 breaks L2TP/IPsec
Summary: net/mpd5: 5.9_10 upstream r2454 breaks L2TP/IPsec
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Eugene Grosbein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-05 08:21 UTC by HATANO Tomomi
Modified: 2022-10-11 12:07 UTC (History)
0 users

See Also:
eugen: maintainer-feedback+

Attachments
mpd 5.9_10 log (1.67 KB, text/plain)
2022-10-05 08:21 UTC, HATANO Tomomi 		no flags Details
proposed fix (431 bytes, patch)
2022-10-05 11:41 UTC, Eugene Grosbein 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description HATANO Tomomi 2022-10-05 08:21:52 UTC 
Created attachment 237093 [details]
mpd 5.9_10 log

I have a L2TP/IPsec box with security/ipsec-tools and net/mpd5.
13.1-RELEASE-p2.
package mpd5-5.9_9 works fine, 5.9_10 doesn't work at all.

I tried:
With upstream r2453, OK.
With r2454, NG.

Please revert r2454.
Comment 1 Eugene Grosbein freebsd_committer freebsd_triage 2022-10-05 10:52:12 UTC 
I doubt that change could be the reason of the breakage.
It seems you have some more differences other than mpd5 version between working and non-working setups.

The log you provided shows that there are no incoming L2TP payload packets passed to mpd5 from the racoon daemon. Please verify what other differences you may have.

If you cannot find it, then I need more detailed mpd5 logs. Please add to "default" section of mpd5:

log +echo +auth +bund +ccp +iface +iface2 +ipcp +lcp +lcp2 +phys +phys2 +phys3 +link

Then retry with the version 5.9_10 and post new log.
Comment 2 Eugene Grosbein freebsd_committer freebsd_triage 2022-10-05 11:25:23 UTC 
I managed to reproduce the problem. Will you be able to test the patch?
Comment 3 Eugene Grosbein freebsd_committer freebsd_triage 2022-10-05 11:41:48 UTC 
Created attachment 237096 [details]
proposed fix

Put the patch to /usr/ports/net/mpd5/files/ directory then rebuild, reinstall and restart mpd5.
Comment 4 HATANO Tomomi 2022-10-06 01:04:20 UTC 
With patch-redial2, works fine.
Thank you.
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-10-06 07:17:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=15c9b10e294e33112d57f3007bcdd7f3efa47a41

commit 15c9b10e294e33112d57f3007bcdd7f3efa47a41
Author:     Eugene Grosbein <eugen@FreeBSD.org>
AuthorDate: 2022-10-06 07:11:55 +0000
Commit:     Eugene Grosbein <eugen@FreeBSD.org>
CommitDate: 2022-10-06 07:16:58 +0000

    net/mpd5: unbreak incoming L2TP connections

    The revision mpd5-5.9_10 broke incoming L2TP connections. Fix it.

    PR:     266838

 net/mpd5/Makefile           | 2 +-
 net/mpd5/files/patch-redial | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Comment 6 Eugene Grosbein freebsd_committer freebsd_triage 2022-10-06 07:20:04 UTC 
Fixed with mpd5-5.9_11.