Bug 266991 - www/luakit-devel: update to 2.3.1-6
Summary: www/luakit-devel: update to 2.3.1-6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-12 13:14 UTC by Marco Beishuizen
Modified: 2022-10-12 19:09 UTC (History)
2 users (show)

See Also:

Attachments
www/luakit-devel: update to 2.3.1-6 (859 bytes, patch)
2022-10-12 13:14 UTC, Marco Beishuizen 		mbeis: maintainer-approval+
Details | Diff
luakit-devel-2.3.1.6,1 v1: Fix DOCS option (12.58 KB, patch)
2022-10-12 15:21 UTC, Nuno Teixeira 		mbeis: maintainer-approval+
Details | Diff
luakit-devel-2.3.1.6,1 v2: Fix DOCS option (final) (10.79 KB, patch)
2022-10-12 16:58 UTC, Nuno Teixeira 		mbeis: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Beishuizen 2022-10-12 13:14:38 UTC 
Created attachment 237237 [details]
www/luakit-devel: update to 2.3.1-6

www/luakit-devel: update to 2.3.1-6
This solves https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266975 too.
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-12 15:21:24 UTC 
Created attachment 237238 [details]
luakit-devel-2.3.1.6,1 v1: Fix DOCS option

Port doc option doesn't control docs installation.
Fix it overriding DOCSDIR since src install default is PREFIX/share/doc/*luakit*
but DOCSDIR defaults to PREFIX/share/doc/PORTNAME(*luakit-devel*)

Looking for a better way to avoid overriding DOCSDIR
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-12 16:58:45 UTC 
Created attachment 237240 [details]
luakit-devel-2.3.1.6,1 v2: Fix DOCS option (final)

- add missing harfbuzz lib depends
- use PKGNAMESUFFIX=-devel instead of including it in PORTNAME
- use PORTDATA and PORTDOCS helpers to reduce pkg-plist and easier updates
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-10-12 19:08:56 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2b9b771202b22799c41a530a17a603497aa2fa2a

commit 2b9b771202b22799c41a530a17a603497aa2fa2a
Author:     Marco Beishuizen <mbeis@xs4all.nl>
AuthorDate: 2022-10-12 18:48:23 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-10-12 19:08:22 +0000

    www/luakit-devel: update to 2.3.1-6

     - Fix DOCS option installation

    PR:             266991

 www/luakit-devel/Makefile  |  11 ++-
 www/luakit-devel/distinfo  |   6 +-
 www/luakit-devel/pkg-plist | 227 ---------------------------------------------
 3 files changed, 11 insertions(+), 233 deletions(-)
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-12 19:09:38 UTC 
Committed, thanks!