Bug 266996 - devel/websvn: update to 2.8.0
Summary: devel/websvn: update to 2.8.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL: https://github.com/websvnphp/websvn/r...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-12 18:31 UTC by Michael Osipov
Modified: 2022-10-14 07:29 UTC (History)
2 users (show)

See Also:
fernape: merge-quarterly+


Attachments
Git-formatted patch (3.54 KB, patch)
2022-10-12 18:31 UTC, Michael Osipov
michael.osipov: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Osipov 2022-10-12 18:31:48 UTC
Created attachment 237242 [details]
Git-formatted patch

Port maintainer and WebSVN maintainer here. Attached is a Git-formatted patch with UPDATING. Fully tested in poudriere from 7.4 to 8.2-RC2. Runs flawlessly now on PHP 8.

If PHP 7.4 will be removed from 2022Q4 this patch needs to be backported from main to it.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-13 05:44:03 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

^Triage: Maintainer-feedback flag (+) not required unless requested (?) first.

Michael, in 2022Q4 there is php7.4, 8.0, 8.1 and 8.2.
What do you mean by "If PHP 7.4 will be removed from 2022Q4"?

Thanks!
Comment 2 Michael Osipov 2022-10-13 07:13:14 UTC
(In reply to Fernando Apesteguía from comment #1)

Look here: https://github.com/freebsd/freebsd-ports/blob/e8745495c33f1fe9c721580a68c058e19632295a/lang/php74/Makefile#L15-L16

It is not clear whether PHP 7.4 will be removed in December from the quarterly branch or not since I get this message on quarterly as well.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-13 15:22:53 UTC
(In reply to Michael Osipov from comment #2)
That means it will be removed from Head, not the quarterly branches. So, in that case I suppose we don't need to MFH this one, right?
Comment 4 Michael Osipov 2022-10-13 17:43:40 UTC
(In reply to Fernando Apesteguía from comment #3)

True, but this will block people to move already to PHP 8 if they want to. Requiring them to wait until January. So almost 1,5 months after the EOL date.

My assumption is that people hopefully finally complete testing with PHP 8 this month and move no later than in November to PHP 8. It took me weeks to get WebSVN to PHP 8 as well as sort out the dependency fixes with the maintainers. Especially horde packages with https://github.com/ralflang who is a horde maintainer.
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-13 19:18:01 UTC
(In reply to Michael Osipov from comment #4)
No problem. I'll land it in 2022Q4 too.

Thanks for the input.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-10-14 05:47:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=df3fca4f09e1dd7c5a320d23b04ebfac02587cd0

commit df3fca4f09e1dd7c5a320d23b04ebfac02587cd0
Author:     Michael Osipov <michael.osipov@siemens.com>
AuthorDate: 2022-10-13 05:38:48 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-10-14 05:43:28 +0000

    devel/websvn: update to 2.8.0

    PR:             266996
    Reported by:    michael.osipov@siemens.com (maintainer)

 UPDATING                          | 10 ++++++++++
 devel/websvn/Makefile             | 13 +++++--------
 devel/websvn/distinfo             |  6 +++---
 devel/websvn/files/pkg-message.in | 17 ++++++++++++-----
 devel/websvn/pkg-plist            |  2 +-
 5 files changed, 31 insertions(+), 17 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-10-14 05:49:52 UTC
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=97985ee0ffbdd729e55efa11a0fbb9ed79f59cb3

commit 97985ee0ffbdd729e55efa11a0fbb9ed79f59cb3
Author:     Michael Osipov <michael.osipov@siemens.com>
AuthorDate: 2022-10-13 05:38:48 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-10-14 05:46:03 +0000

    devel/websvn: update to 2.8.0

    PR:             266996
    Reported by:    michael.osipov@siemens.com (maintainer)

    (cherry picked from commit df3fca4f09e1dd7c5a320d23b04ebfac02587cd0)

 UPDATING                          | 10 ++++++++++
 devel/websvn/Makefile             | 13 +++++--------
 devel/websvn/distinfo             |  6 +++---
 devel/websvn/files/pkg-message.in | 17 ++++++++++++-----
 devel/websvn/pkg-plist            |  2 +-
 5 files changed, 31 insertions(+), 17 deletions(-)
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-14 05:50:09 UTC
Committed and merged to 2022Q4,

Thanks!
Comment 9 Michael Osipov 2022-10-14 07:29:28 UTC
(In reply to Fernando Apesteguía from comment #8)

Thanks you Fernando, you fast help you very much appereciated!