Bug 267065 - audio/ardour6 build works with python 3.9 can the build depend be bumped to 3.7+ to allow default python use
Summary: audio/ardour6 build works with python 3.9 can the build depend be bumped to 3...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords: patch
Depends on: 267868
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-15 06:34 UTC by alt2600
Modified: 2022-12-26 07:18 UTC (History)
3 users (show)

See Also:


Attachments
git-ardour6-allow-py37+.diff (550 bytes, patch)
2022-10-15 06:34 UTC, alt2600
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description alt2600 2022-10-15 06:34:16 UTC
Created attachment 237317 [details]
git-ardour6-allow-py37+.diff

port can be built using python 3.9, can we change the build dependency from 

python:3.7

to 

python:3.7+

so users can avoid having multiple pythons installed when building from ports
Comment 1 Florian Walpen 2022-10-18 16:13:34 UTC
Seconded - builds fine with python 3.9

Please note that Ardour 7.0 was just released:
https://ardour.org/whatsnew.html

I'll probably work on a port this weekend, unless somebody else wants to.
Comment 2 Florian Walpen 2022-11-19 21:17:35 UTC
(In reply to Florian Walpen from comment #1)

Update to 7.1.0 took some more time than expected, but it's here now - see bug #267868.

Please note that the update changes the port directory, which means the patch discussed here won't apply after the update. But the update already includes the relaxed python build dependency.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-12-26 07:15:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e5453d2a9f4944a40f4e10df52b3f360746f7414

commit e5453d2a9f4944a40f4e10df52b3f360746f7414
Author:     Florian Walpen <dev@submerge.ch>
AuthorDate: 2022-12-26 07:07:01 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-12-26 07:14:35 +0000

    audio/ardour: Update to 7.2.0 release, replace audio/ardour6

     - Submitter becomes maintainer

    This patch provides an update to Ardour 7.1.0, thereby replacing Ardour
    6.9.0 in audio/ardour6 and moving the port to audio/ardour. There's no
    reason to keep the major version in the portname, we only had one version
    for quite some time.

    The patch also incorporates bug #267065, relaxing the version requirement
    on the python build dependency.

    Some notes about the changes I made:

    Issue 1 - Official download is now tailored to browsers only, that's why
    the distfile is named "510". Put it in a named and versioned subdirectory
    to not mess up the distfiles directory. I didn't find a better download
    alternative. Github is not an option, because the download there is
    deliberately made empty (sic).

    Issue 2 - Even though I followed the advice in the porters handbook to
    the best of my knowledge, portlint warns about the use of DISTFILES and
    DISTNAME. The problem is the odd distfile name (Issue 1) combined with
    non-matching extraction path and portname. If I follow the suggestions of
    portlint, I have to define WRKSRC above the license block which portlint
    doesn't like either.

    Issue 3 - Ardour includes its major version (e.g. "ardour7") in many
    pkg-plist paths. I factored these out into a substitution variable named
    ARDOUR_MAJOR, to ease future updates to the port. Some of these
    substitutions came through the portname previously.

    ChangeLog:      https://ardour.org/whatsnew.html
    PR:             267065, 267868

 MOVED                                              |   2 +-
 audio/Makefile                                     |   2 +-
 audio/ardour/Makefile (new)                        | 102 ++++++++
 audio/ardour/distinfo (new)                        |   3 +
 audio/{ardour6 => ardour}/pkg-descr                |   0
 audio/{ardour6 => ardour}/pkg-plist                | 260 +++++++++++----------
 audio/ardour6/Makefile (gone)                      | 116 ---------
 audio/ardour6/distinfo (gone)                      |   3 -
 .../patch-libs_ardour_plugin__manager.cc (gone)    |  18 --
 9 files changed, 246 insertions(+), 260 deletions(-)
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-26 07:18:33 UTC
Committed, thanks!