Bug 267116 - misc/orion: fails to build with mpv 0.35
Summary: misc/orion: fails to build with mpv 0.35
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords: needs-patch
Depends on:
Blocks: 267113
  Show dependency tree / graph
 
Reported: 2022-10-16 06:07 UTC by Jan Beich
Modified: 2022-10-16 16:31 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
poudriere error log (108.12 KB, text/plain)
2022-10-16 06:08 UTC, Jan Beich 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2022-10-16 06:07:58 UTC 
Regressed by http://github.com/mpv-player/mpv/commit/632059816add. Can you provide a fix or ask upstream? Otherwise, this port will be marked BROKEN or switched to mpv034 (port fork).

src/player/mpvobject.cpp:73:82: error: excess elements in struct initializer
            mpv_opengl_init_params gl_init_params{get_proc_address_mpv, nullptr, nullptr};
                                                                                 ^~~~~~~
src/player/mpvobject.cpp:282:18: error: use of undeclared identifier 'MPV_EVENT_UNPAUSE'; did you mean 'MPV_EVENT_NONE'?
            case MPV_EVENT_UNPAUSE:
                 ^~~~~~~~~~~~~~~~~
                 MPV_EVENT_NONE
/usr/local/include/mpv/client.h:1223:5: note: 'MPV_EVENT_NONE' declared here
    MPV_EVENT_NONE              = 0,
    ^
src/player/mpvobject.cpp:284:18: error: use of undeclared identifier 'MPV_EVENT_PAUSE'
            case MPV_EVENT_PAUSE:
                 ^
Comment 1 Jan Beich freebsd_committer freebsd_triage 2022-10-16 06:08:51 UTC 
Created attachment 237371 [details]
poudriere error log
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-10-16 09:36:56 UTC 
Dead upstream, remove it? https://github.com/alamminsalo/orion/
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2022-10-16 16:30:41 UTC 
Port removed.
Thanks for reporting.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-10-16 16:31:11 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=120fb395c8794f70bf719c3975ddb763b11c7dd6

commit 120fb395c8794f70bf719c3975ddb763b11c7dd6
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2022-10-16 16:29:10 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-10-16 16:30:46 +0000

    misc/orion: Remove because it is breaking with mpv-0.35 and it is dead upstream

    PR:             267116
    Reported by:    jbeich

 MOVED                       |  1 +
 misc/Makefile               |  1 -
 misc/orion/Makefile (gone)  | 32 --------------------------------
 misc/orion/distinfo (gone)  |  3 ---
 misc/orion/pkg-descr (gone) |  8 --------
 5 files changed, 1 insertion(+), 44 deletions(-)