Bug 267214 - sysutils/nut*: remove bash-completion dependencies
Summary: sysutils/nut*: remove bash-completion dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-20 00:59 UTC by Mel Pilgrim
Modified: 2022-12-12 14:44 UTC (History)
4 users (show)

See Also:
cy: maintainer-feedback+
cy: merge-quarterly+

Attachments
Patch to drop bash-completion dependencies (1.30 KB, text/plain)
2022-10-20 00:59 UTC, Mel Pilgrim 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mel Pilgrim 2022-10-20 00:59:35 UTC 
Created attachment 237471 [details]
Patch to drop bash-completion dependencies

If the user doesn't disable the option to install the bash completions, it adds unnecessary build and run dependencies on sysutils/bash-completions.

There is precedent for not having that dependency: devel/git and sysutils/tmux, for example, install bash completion scripts without depending on sysutils/bash-completions.
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2022-10-20 06:17:04 UTC 
I agree.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-10-22 17:19:18 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6d2af9e3f07a2473b50b02388a58708ad5015cf5

commit 6d2af9e3f07a2473b50b02388a58708ad5015cf5
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2022-10-20 06:16:36 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2022-10-22 16:58:46 +0000

    sysutils/nut*: Remove bash_completion dependency

    Even though bash completion scripts are installed, bash_completion
    need not be installed, reducing the port and package footprint.
    Should a person actually need bash_completion, it can be installed
    separately by the user.

    PR:             267214
    Reported by:    Mel Pilgrim <ports.maintainer@evilphi.com>
    MFH:            2022Q4

 sysutils/nut-devel/Makefile | 4 +---
 sysutils/nut/Makefile       | 5 +----
 2 files changed, 2 insertions(+), 7 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-10-25 04:11:19 UTC 
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cffab136e17b6298b4f3480b137467f185523478

commit cffab136e17b6298b4f3480b137467f185523478
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2022-10-20 06:16:36 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2022-10-25 04:09:58 +0000

    sysutils/nut*: Remove bash_completion dependency

    Even though bash completion scripts are installed, bash_completion
    need not be installed, reducing the port and package footprint.
    Should a person actually need bash_completion, it can be installed
    separately by the user.

    PR:             267214
    Reported by:    Mel Pilgrim <ports.maintainer@evilphi.com>
    MFH:            2022Q4

    (cherry picked from commit 6d2af9e3f07a2473b50b02388a58708ad5015cf5)

 sysutils/nut-devel/Makefile | 4 +---
 sysutils/nut/Makefile       | 5 +----
 2 files changed, 2 insertions(+), 7 deletions(-)