Bug 267507 - www/darkhttpd: Update to 1.14 (Fixes CVE-2020-25691)
Summary: www/darkhttpd: Update to 1.14 (Fixes CVE-2020-25691)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Fernando Apesteguía
URL: https://github.com/emikulic/darkhttpd...
Keywords: needs-patch, needs-qa, security
Depends on:
Blocks:
 
Reported: 2022-11-01 20:40 UTC by Henrich Hartzer
Modified: 2022-11-08 16:39 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback? (henrichhartzer)
fernape: merge-quarterly+


Attachments
Patch (1.14 KB, patch)
2022-11-01 20:40 UTC, Henrich Hartzer
no flags Details | Diff
Patch with maintainer fix (1.31 KB, patch)
2022-11-02 02:20 UTC, Henrich Hartzer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Henrich Hartzer 2022-11-01 20:40:37 UTC
Created attachment 237796 [details]
Patch

Would appreciate if this can also be backported to quarterly: CVE-2020-25691

Thanks!
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2022-11-01 20:40:37 UTC
Maintainer informed via mail
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2022-11-01 22:32:03 UTC
Thank you for the update Henrich. 

Is the MAINTAINER email address in the current port incorrect? It appears to be typo'd. Could you confirm/clarify?

^Triage: 

 - If there is a changelog or release notes URL available for this version, please add it to the URL field

 - This change needs a security/vuxml entry
Comment 3 Henrich Hartzer 2022-11-02 02:20:54 UTC
Created attachment 237799 [details]
Patch with maintainer fix
Comment 4 Henrich Hartzer 2022-11-02 02:22:38 UTC
You are right! I got my email wrong. Thank you for noticing.

What do you mean by the URL field? How would I update vuxml?

Thanks!
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2022-11-07 19:18:45 UTC
(In reply to Henrich Hartzer from comment #4)
Here: https://docs.freebsd.org/en/books/porters-handbook/security/#security-notify-vuxml-intro
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2022-11-07 19:20:28 UTC
^Triage: Yes, the URL field.

Q/A: PORTREVISION should be removed. NO NEED to update a new patch for that, though.


Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-11-08 16:35:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bbe3b93c5dcb484cef6ecf4fdabfeff7e64d3737

commit bbe3b93c5dcb484cef6ecf4fdabfeff7e64d3737
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2022-11-08 16:29:21 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-11-08 16:30:57 +0000

    security/vuxml: register darkhttpd DoS vulnerability

    PR:             267507
    Reported by:    Henrich Hartzer <henrichhartzer@tuta.io>
    Security:       CVE-2020-25691

 security/vuxml/vuln-2022.xml | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-11-08 16:36:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1de880e0f6277e22d81d68cba532656dc58b207a

commit 1de880e0f6277e22d81d68cba532656dc58b207a
Author:     Henrich Hartzer <henrichhartzer@tuta.io>
AuthorDate: 2022-11-07 19:17:19 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-11-08 16:31:41 +0000

    www/darkhttpd: Update to 1.14 (Fixes CVE-2020-25691)

    ChangeLog: https://github.com/emikulic/darkhttpd/releases/tag/v1.14

     * Add support for logging with syslog.
     * Fix hung connection from consecutive keep-alive requests.
     * Fix high CPU usage when timeout is disabled.
     * Add --forward-https.
     * Make header parsing case insensitive, to work behind an HTTP2 reverse proxy.
     * Add trailing slash to links for directories.
     * Fix crash when a file has a large (year 10,000+) mtime.

    A flaw was found in darkhttpd. Invalid error handling allows remote attackers
    to cause denial-of-service by accessing a file with a large modification date.
    The highest threat from this vulnerability is to system availability.

    PR:             267507
    Reported by:    henrichhartzer@tuta.io
    MFH:            2022Q4 (security update)
    Security:       CVE-2020-25691

 www/darkhttpd/Makefile | 5 ++---
 www/darkhttpd/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 6 deletions(-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2022-11-08 16:38:46 UTC
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2f5b21e40a831efb7e7e276fcb3de1a50bf8fc24

commit 2f5b21e40a831efb7e7e276fcb3de1a50bf8fc24
Author:     Henrich Hartzer <henrichhartzer@tuta.io>
AuthorDate: 2022-11-07 19:17:19 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-11-08 16:34:05 +0000

    www/darkhttpd: Update to 1.14 (Fixes CVE-2020-25691)

    ChangeLog: https://github.com/emikulic/darkhttpd/releases/tag/v1.14

     * Add support for logging with syslog.
     * Fix hung connection from consecutive keep-alive requests.
     * Fix high CPU usage when timeout is disabled.
     * Add --forward-https.
     * Make header parsing case insensitive, to work behind an HTTP2 reverse proxy.
     * Add trailing slash to links for directories.
     * Fix crash when a file has a large (year 10,000+) mtime.

    A flaw was found in darkhttpd. Invalid error handling allows remote attackers
    to cause denial-of-service by accessing a file with a large modification date.
    The highest threat from this vulnerability is to system availability.

    PR:             267507
    Reported by:    henrichhartzer@tuta.io
    MFH:            2022Q4 (security update)
    Security:       CVE-2020-25691

    (cherry picked from commit 1de880e0f6277e22d81d68cba532656dc58b207a)

 www/darkhttpd/Makefile | 4 ++--
 www/darkhttpd/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
Comment 10 Fernando Apesteguía freebsd_committer freebsd_triage 2022-11-08 16:39:32 UTC
Committed, merged to 2022Q4 and vuxml entry added.

Thanks!