Bug 268216 - www/apache24: htcacheclean rcscript appears too early in rcorder
Summary: www/apache24: htcacheclean rcscript appears too early in rcorder
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-07 04:07 UTC by Tatsuki Makino
Modified: 2023-06-03 18:41 UTC (History)
2 users (show)

See Also:
diizzy: maintainer-feedback-

Attachments
patch for www/apache24 (366 bytes, patch)
2022-12-07 04:07 UTC, Tatsuki Makino 		freebsd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tatsuki Makino 2022-12-07 04:07:20 UTC 
Created attachment 238592 [details]
patch for www/apache24

Because htcacheclean has no dependencies set, it runs before the file system is ready, even though it makes changes to the file system.
A dependency on FILESYSTEMS or at least mountcritlocal is required.

The usage before this fixing was service htcacheclean onestart with htcacheclean_enable=NO.

Unrelated, but there are several scripts in /etc/rc.d/* in the same state (e.g. bug 215368, bug 268157...).
Comment 1 Tatsuki Makino 2022-12-07 06:41:47 UTC 
Sorry, scripts under ${LOCALBASE}/etc/rc.d/ are always executed in "pass 2", so they could not be eligible for early_late_divider="FILESYSTEMS".
However, explicitly listing it would still be effective in a LOCALBASE=/ or LOCALBASE="" environment :)
Comment 2 Mina Galić freebsd_triage 2023-05-21 10:18:15 UTC 
Maintainer timeout.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-06-03 18:41:03 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8c00446980aa6183cfe318347595900ac8a82d69

commit 8c00446980aa6183cfe318347595900ac8a82d69
Author:     Tatsuki Makino <tatsuki_makino@hotmail.com>
AuthorDate: 2023-06-03 18:33:34 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-06-03 18:40:08 +0000

    www/apache24: htcacheclean rc.d script appears too early in rcorder

    Because htcacheclean has no dependencies set, it runs before the
    file system is ready, even though it makes changes to the file system.
    Define FILESYSTEMS as requirement to fix this race condition.

    PR:             268216
    Approved by:    portmgr (maintainer timeout, 5+ months)

 www/apache24/Makefile              | 1 +
 www/apache24/files/htcacheclean.in | 2 ++
 2 files changed, 3 insertions(+)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2023-06-03 18:41:36 UTC 
Commited, thanks and sorry for the wait!